Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 689070 - media-libs/mlt: re-enable sdl1
Summary: media-libs/mlt: re-enable sdl1
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2019-07-01 09:14 UTC by 4nykey
Modified: 2019-10-21 21:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
adds (mlt-sdl2.diff,1.90 KB, patch)
2019-07-01 09:14 UTC, 4nykey
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description 4nykey 2019-07-01 09:14:31 UTC
Created attachment 581604 [details, diff]
adds

Please re-enable SDLv1 module.
Tested locally, builds and runs with no apparent side effects.
Use flag name is of no significance, just please don't kill it. Thank you!
Comment 1 Andreas Sturmlechner gentoo-dev 2019-07-01 09:16:57 UTC
What for?
Comment 2 Andreas Sturmlechner gentoo-dev 2019-07-01 09:19:59 UTC
Please note your change would re-introduce bug 656904 and break reverse-dependencies that depend on mlt[sdl] right now.
Comment 3 4nykey 2019-07-01 09:29:42 UTC
(In reply to Andreas Sturmlechner from comment #1)
> What for?
Just for the heck of it. Because it doesn't break anything. At the very last there are certain use cases https://github.com/jliljebl/flowblade/blob/v2.0/flowblade-trunk/docs/SDL_2_AND_MLT_6_6_0.md

(In reply to Andreas Sturmlechner from comment #2)
> Please note your change would re-introduce bug 656904 and break reverse-dependencies that depend on mlt[sdl] right now
Name it sdl1, or whatever's appropriate, doesn't matter.
Comment 4 Andreas Sturmlechner gentoo-dev 2019-07-01 09:34:49 UTC
(In reply to ak from comment #3)
> (In reply to Andreas Sturmlechner from comment #1)
> > What for?
> Just for the heck of it. Because it doesn't break anything.
That's not enough to justify the change, and I just showed you it does break mlt.

(In reply to ak from comment #3)
> At the very last there are certain use cases
> https://github.com/jliljebl/flowblade/blob/v2.0/flowblade-trunk/docs/
> SDL_2_AND_MLT_6_6_0.md
flowblade is not in Gentoo ebuild repository, and its upstream should rather be encouraged to get rid of that limitation.
Comment 5 4nykey 2019-07-01 09:58:19 UTC
(In reply to Andreas Sturmlechner from comment #4)
> That's not enough to justify the change,
Marvellous. Is that your personal decision or Gentoo policy?

> and I just showed you it does break mlt.
You did? For the third time, disregard use flags, forget the attached diff, let's forget I ever proposed anything related to use flags.
Comment 6 Andreas Sturmlechner gentoo-dev 2019-07-01 10:34:27 UTC
(In reply to ak from comment #5)
> (In reply to Andreas Sturmlechner from comment #4)
> > That's not enough to justify the change,
> Marvellous. Is that your personal decision or Gentoo policy?
Not reintroducing a crash 'for the heck of it' would appear to be the policy of every maintainer in every distribution, no need to sour about it. Did you check the link I provided?
Comment 7 4nykey 2019-07-01 11:16:07 UTC
(In reply to Andreas Sturmlechner from comment #6)
> (In reply to ak from comment #5)
> > (In reply to Andreas Sturmlechner from comment #4)
> > > That's not enough to justify the change,
> > Marvellous. Is that your personal decision or Gentoo policy?
> Not reintroducing a crash 'for the heck of it' would appear to be the policy
> of every maintainer in every distribution, no need to sour about it. Did you
> check the link I provided?

You mean bug 656904? Doesn't seem relevant anymore. How do I check? There's no instructions how to reproduce.
Comment 8 4nykey 2019-07-01 11:17:26 UTC
Oh and there's a way to let the user choose which sdl version he wants via REQUIRED_USE, i believe
Comment 9 Andreas Sturmlechner gentoo-dev 2019-10-21 21:04:40 UTC
So, 2.5 months later there is still nothing in tree demanding sdl1 from mlt.

For flowblade, you can track this issue for their porting to sdl2: https://github.com/jliljebl/flowblade/issues/603

Any overlay that might provide this package shall fork our mlt ebuild to meet its demand. For personal use, Gentoo gives you all the tools you need to roll your own.