688872 – CPU_FLAGS_X86 local flags in packages

Bug 688872 - CPU_FLAGS_X86 local flags in packages

Summary: CPU_FLAGS_X86 local flags in packages

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Quality Assurance Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2019-06-28 09:58 UTC by Michał Górny
Modified:	2019-07-16 06:10 UTC (History)
CC List:	4 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2019-06-28 09:58:10 UTC

CPU_FLAGS_X86 is USE_EXPAND, so it's global by definition.  Adding additional local flags is both technically wrong, and harms users by not having them properly defined globally.


dev-libs/nettle/metadata.xml:           <flag name="cpu_flags_x86_sha">Enable support for Intel's SHA instruction set (SHA-NI)</flag>
media-libs/babl/metadata.xml:           <flag name='cpu_flags_x86_f16c'>Take advantage of CPU feature f16c</flag>
media-libs/openimageio/metadata.xml:            <flag name="cpu_flags_x86_avx512f">SIMD Optimization</flag>
media-libs/openimageio/metadata.xml:            <flag name="cpu_flags_x86_f16c">SIMD Optimization</flag>
media-libs/osl/metadata.xml:            <flag name="cpu_flags_x86_avx512f" restrict="&gt;=media-libs/osl-1.9.0">
media-libs/osl/metadata.xml:            <flag name="cpu_flags_x86_f16c" restrict="&gt;=media-libs/osl-1.9.0">

I think I've CC-ed all people responsible for adding them.  Now please kindly send patches to -dev making them global flags properly, and since you failed to follow policy in the first place, please kindly send patches to cpuid2cpuflags [1] as well.

[1] https://github.com/mgorny/cpuid2cpuflags

Comment 1 Michał Górny archtester

2019-07-16 06:10:34 UTC

All gone.  The vandalism related to sha flag removal will be handled separately.