Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 688858 - app-portage/cpuid2cpuflags should support cpu_flags_x86_sha for dev-libs/nettle
Summary: app-portage/cpuid2cpuflags should support cpu_flags_x86_sha for dev-libs/nettle
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-27 21:06 UTC by Andrei Slavoiu
Modified: 2019-10-21 15:00 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Slavoiu 2019-06-27 21:06:07 UTC
app-portage/cpuid2cpuflags is the recomended way to set CPU_FLAGS_X86 variable, but it does not handle the sha flag so nettle will not have it enable even if the CPU supports it.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-06-28 09:50:33 UTC
My first question would be, why was this added as a local flag in the first place?  It obviously collides with global USE_EXPAND.
Comment 2 Alon Bar-Lev (RETIRED) gentoo-dev 2019-06-28 11:24:47 UTC
And my answer would be not to block the bump until formalizing the new use flag name and the tuning of profiles.

Once there will be a formal global flag and profiles proper masks, package will be modified.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-06-29 09:50:46 UTC
(In reply to Alon Bar-Lev from comment #2)
> And my answer would be not to block the bump until formalizing the new use
> flag name and the tuning of profiles.
> 
> Once there will be a formal global flag and profiles proper masks, package
> will be modified.

So when are you planning to do this correctly and remove the band-aid?
Comment 4 Alon Bar-Lev (RETIRED) gentoo-dev 2019-06-29 16:23:50 UTC
> So when are you planning to do this correctly and remove the band-aid?

I believe  I replied per dev-libs/nettle:

I will be more than happy to:
1. remove the entire functionality now.
2. rename the USE flag until there will be a global flag.
3. remove the local USE description once there will be a global flag.

Pick the option you like, as I picked (3) as I believe it serves users the best until app-portage/cpuid2cpuflags is updated.
Comment 5 Larry the Git Cow gentoo-dev 2019-07-08 13:31:46 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d0c54ca151d04776d24da5ca81be96155659ce36

commit d0c54ca151d04776d24da5ca81be96155659ce36
Author:     Alon Bar-Lev <alonbl@gentoo.org>
AuthorDate: 2019-07-08 13:24:03 +0000
Commit:     Alon Bar-Lev <alonbl@gentoo.org>
CommitDate: 2019-07-08 13:31:17 +0000

    dev-libs/nettle: USE cpu_flags_x86_sha->preview-cpu_flags_x86_sha
    
    A temporary solution until cpu_flags_x86_sha available.
    
    Bug: https://bugs.gentoo.org/show_bug.cgi?id=688858
    Signed-off-by: Alon Bar-Lev <alonbl@gentoo.org>
    Package-Manager: Portage-2.3.66, Repoman-2.3.11

 dev-libs/nettle/metadata.xml        | 2 +-
 dev-libs/nettle/nettle-3.5.1.ebuild | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2019-07-08 13:43:09 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ebd359904856d99cbf2cbba6abc96ef183528e6f

commit ebd359904856d99cbf2cbba6abc96ef183528e6f
Author:     Alon Bar-Lev <alonbl@gentoo.org>
AuthorDate: 2019-07-08 13:38:49 +0000
Commit:     Alon Bar-Lev <alonbl@gentoo.org>
CommitDate: 2019-07-08 13:42:49 +0000

    dev-libs/nettle: remove preview-cpu_flags_x86_sha
    
    Bug: https://bugs.gentoo.org/show_bug.cgi?id=688858
    Signed-off-by: Alon Bar-Lev <alonbl@gentoo.org>
    Package-Manager: Portage-2.3.66, Repoman-2.3.11

 dev-libs/nettle/metadata.xml        | 3 ---
 dev-libs/nettle/nettle-3.5.1.ebuild | 4 ++--
 2 files changed, 2 insertions(+), 5 deletions(-)
Comment 7 Ulrich Müller gentoo-dev 2019-10-21 15:00:45 UTC
Closing per commit https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b849cbe2f94883b679570753863ceebd364f2be7:

commit b849cbe2f94883b679570753863ceebd364f2be7
Author: Michał Górny <mgorny@gentoo.org>
Date:   Thu Jul 18 16:54:24 2019 +0200

    dev-libs/nettle: [QA] Revert cpu_flags_x86_sha removal
    
    Reverts: ebd359904856d99cbf2cbba6abc96ef183528e6f
    Reverts: d0c54ca151d04776d24da5ca81be96155659ce36
    Signed-off-by: Michał Górny <mgorny@gentoo.org>