688788 – [kde overlay] kde-apps/gwenview-9999 USE=-kipi - ../gwenview-9999/app/mainwindow.cpp:203:5: error: 'KToolBarPopupAction' does not name a type

Bug 688788 - [kde overlay] kde-apps/gwenview-9999 USE=-kipi - ../gwenview-9999/app/mainwindow.cpp:203:5: error: 'KToolBarPopupAction' does not name a type

Summary: [kde overlay] kde-apps/gwenview-9999 USE=-kipi - ../gwenview-9999/app/mainwin...

Status:	RESOLVED UPSTREAM

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Overlays (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Gentoo KDE team

URL:	https://phabricator.kde.org/D22117
Whiteboard:	tracking upstream
Keywords:

Depends on:
Blocks:

Reported:	2019-06-27 08:39 UTC by Duncan
Modified:	2019-06-28 18:27 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Duncan 2019-06-27 08:39:58 UTC

This is a followup to bug #688516, still dealing with the fallout from upstream adding the purpose dependency.

Now, with purpose installed (thanks to the hard dep from the fix for the first bug) but with USE=-kipi, I get almost done compiling (188/189 shows up) and get this:

[188/189] /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -DKCOREADDONS_LIB -DPHONON_LIB_SONAME=\"phonon4qt5\" -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_NO_URL_CAST_FROM_STRING -DQT_OPENGL_LIB -DQT_PRINTSUPPORT_LIB -DQT_SVG_LIB -DQT_WIDGETS_LIB -DQT_X11EXTRAS_LIB-DQT_XML_LIB -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -Iapp -I/tmp/portage/kde-apps/gwenview-9999/work/gwenview-9999/app -Iapp/gwenview_autogen/include -I. -I/tmp/portage/kde-apps/gwenview-9999/work/gwenview-9999/app/.. -Iapp/.. -Ilib -I/tmp/portage/kde-apps/gwenview-9999/work/gwenview-9999/lib -I/usr/include/phonon4qt5/KDE -isystem /usr/include/phonon4qt5 -isystem /usr/include/KF5/KItemModels -isystem /usr/include/KF5 -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/KF5/KNotifications -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui-isystem /usr/include/qt5/QtDBus -isystem /usr/include/KF5/purposewidgets -isystem /usr/include/KF5/purpose -isystem /usr/include/KF5/KCoreAddons -isystem /usr/include/qt5/QtConcurrent -isystem /usr/include/qt5/QtSvg -isystem /usr/include/qt5/QtOpenGL -isystem /usr/include/qt5/QtPrintSupport -isystem /usr/include/KF5/KIOCore -isystem /usr/include/KF5/KService -isystem /usr/include/KF5/KConfigCore -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/KF5/KIOWidgets -isystem /usr/include/KF5/KJobWidgets -isystem /usr/include/KF5/KCompletion -isystem /usr/include/KF5/KWidgetsAddons -isystem /usr/include/KF5/KIOFileWidgets -isystem /usr/include/KF5/KBookmarks -isystem /usr/include/qt5/QtXml -isystem /usr/include/KF5/KItemViews -isystem /usr/include/KF5/KXmlGui -isystem /usr/include/KF5/KConfigWidgets -isystem /usr/include/KF5/KCodecs -isystem /usr/include/KF5/KConfigGui -isystem /usr/include/KF5/KAuth -isystem /usr/include/KF5/Solid -isystem /usr/include/KF5/KI18n -isystem /usr/include/KF5/KWindowSystem -isystem /usr/include/KF5/KIconThemes -isystem /usr/include/qt5/QtX11Extras  -DQT_NO_DEBUG -DNDEBUG -march=native -O2 -fgcse-sm -fgcse-las -fgcse-after-reload -ftree-vectorize -std=c++0x -fno-operator-names -fno-exceptions -Wall -Wextra-Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Wvla -Wdate-time -Wsuggest-override -Wlogical-op -fdiagnostics-color=always -fvisibility=hidden -fvisibility-inlines-hidden   -fPIC -std=gnu++11 -MD -MT app/CMakeFiles/gwenview.dir/mainwindow.cpp.o -MF app/CMakeFiles/gwenview.dir/mainwindow.cpp.o.d -o app/CMakeFiles/gwenview.dir/mainwindow.cpp.o -c /tmp/portage/kde-apps/gwenview-9999/work/gwenview-9999/app/mainwindow.cpp
FAILED: app/CMakeFiles/gwenview.dir/mainwindow.cpp.o 
/usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -DKCOREADDONS_LIB -DPHONON_LIB_SONAME=\"phonon4qt5\" -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB-DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_NO_URL_CAST_FROM_STRING -DQT_OPENGL_LIB -DQT_PRINTSUPPORT_LIB -DQT_SVG_LIB -DQT_WIDGETS_LIB -DQT_X11EXTRAS_LIB -DQT_XML_LIB -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -Iapp -I/tmp/portage/kde-apps/gwenview-9999/work/gwenview-9999/app -Iapp/gwenview_autogen/include -I. -I/tmp/portage/kde-apps/gwenview-9999/work/gwenview-9999/app/.. -Iapp/.. -Ilib -I/tmp/portage/kde-apps/gwenview-9999/work/gwenview-9999/lib -I/usr/include/phonon4qt5/KDE -isystem /usr/include/phonon4qt5 -isystem /usr/include/KF5/KItemModels -isystem /usr/include/KF5 -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/KF5/KNotifications -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtDBus -isystem /usr/include/KF5/purposewidgets -isystem /usr/include/KF5/purpose -isystem /usr/include/KF5/KCoreAddons -isystem /usr/include/qt5/QtConcurrent -isystem /usr/include/qt5/QtSvg -isystem /usr/include/qt5/QtOpenGL -isystem /usr/include/qt5/QtPrintSupport -isystem /usr/include/KF5/KIOCore -isystem /usr/include/KF5/KService -isystem /usr/include/KF5/KConfigCore -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/KF5/KIOWidgets -isystem /usr/include/KF5/KJobWidgets -isystem /usr/include/KF5/KCompletion -isystem /usr/include/KF5/KWidgetsAddons -isystem /usr/include/KF5/KIOFileWidgets -isystem /usr/include/KF5/KBookmarks -isystem /usr/include/qt5/QtXml -isystem /usr/include/KF5/KItemViews -isystem /usr/include/KF5/KXmlGui -isystem /usr/include/KF5/KConfigWidgets -isystem /usr/include/KF5/KCodecs -isystem /usr/include/KF5/KConfigGui -isystem /usr/include/KF5/KAuth -isystem /usr/include/KF5/Solid -isystem /usr/include/KF5/KI18n -isystem /usr/include/KF5/KWindowSystem -isystem /usr/include/KF5/KIconThemes -isystem /usr/include/qt5/QtX11Extras  -DQT_NO_DEBUG -DNDEBUG -march=native -O2 -fgcse-sm -fgcse-las -fgcse-after-reload -ftree-vectorize -std=c++0x -fno-operator-names -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Wvla -Wdate-time -Wsuggest-override -Wlogical-op -fdiagnostics-color=always -fvisibility=hidden -fvisibility-inlines-hidden   -fPIC -std=gnu++11 -MD -MT app/CMakeFiles/gwenview.dir/mainwindow.cpp.o -MF app/CMakeFiles/gwenview.dir/mainwindow.cpp.o.d -o app/CMakeFiles/gwenview.dir/mainwindow.cpp.o -c /tmp/portage/kde-apps/gwenview-9999/work/gwenview-9999/app/mainwindow.cpp
../gwenview-9999/app/mainwindow.cpp:203:5: error: 'KToolBarPopupAction' does not name a type
203 |     KToolBarPopupAction* mShareAction;
|     ^~~~~~~~~~~~~~~~~~~
../gwenview-9999/app/mainwindow.cpp: In member function 'void Gwenview::MainWindow::Private::setupActions()':
../gwenview-9999/app/mainwindow.cpp:515:9: error: 'mShareAction' was not declared in this scope; did you mean 'clearAction'?
515 |         mShareAction = new KToolBarPopupAction(QIcon::fromTheme("document-share"), "Share", q);
|         ^~~~~~~~~~~~
|         clearAction
../gwenview-9999/app/mainwindow.cpp:515:28: error: expected type-specifier before 'KToolBarPopupAction'
515 |         mShareAction = new KToolBarPopupAction(QIcon::fromTheme("document-share"), "Share", q);
|                            ^~~~~~~~~~~~~~~~~~~
../gwenview-9999/app/mainwindow.cpp: In member function 'void Gwenview::MainWindow::Private::updateActions()':
../gwenview-9999/app/mainwindow.cpp:724:13: error: 'mShareAction' was not declared in this scope
724 |             mShareAction->setEnabled(false);
|             ^~~~~~~~~~~~
../gwenview-9999/app/mainwindow.cpp:726:13: error: 'mShareAction' was not declared in this scope
726 |             mShareAction->setEnabled(true);
|             ^~~~~~~~~~~~
ninja: build stopped: subcommand failed.


I thought it was still a problem with purpose and tried different versions of it, tried setting USE=kaccounts for purpose, waited a few days, etc, but the problem didn't go away.

So I tried building with USE=kipi, and low and behold, it worked!

So upstream bug, with kipi required even tho it's still supposed to be optional, or gentoo/kde's bug?

Comment 1 Andreas Sturmlechner gentoo-dev

2019-06-27 10:27:31 UTC

Please always attach a full build.log.

Comment 2 Andreas Sturmlechner gentoo-dev

2019-06-27 10:46:16 UTC

Thanks for the report, fix is pending upstream.

Comment 3 Duncan 2019-06-27 11:53:59 UTC

(In reply to Andreas Sturmlechner from comment #2)
> Thanks for the report, fix is pending upstream.

The diff at the phab $URL is a confirmed fix.  Thanks.  (Tried with USE=kipi and with USE=-kipi with kipi merged, and with USE=-kipi without kipi merged, all three work with the patch.)

And sorry about forgetting the full build log.