Created attachment 580340 [details] build.log FAIL: test-builder 16 /builder/valid-date # test-builder: assertion failed ((0UL) == rv): (0 == 19) # test-builder: in test_valid_dates() at test-builder.c:816
Created attachment 580342 [details] emerge --info
Created attachment 580358 [details] test-suite.log
Hi, Can you please try the latest version now in portage? If it fails, I need your help, please check what branch returns false in type_date[1], you can add printf() before the return, if this is difficult I will send you a patch. Thanks! [1] https://github.com/p11-glue/p11-kit/blob/master/trust/builder.c#L241
It's https://github.com/p11-glue/p11-kit/blob/master/trust/builder.c#L270 tm.tm_mday == 10 two.tm_mday == 9
Thanks! Can you dump all fields in tm and two? What is your timezone?
{printf("%i %i %i vs %i %i %i\n", tm.tm_year, tm.tm_mon, tm.tm_mday, two.tm_year, two.tm_mon, two.tm_mday); return false;} 100 10 10 vs 100 10 9 Europe/Dublin
Created attachment 581418 [details] a.c We need to reproduce this outside of package... very strange. Please see this file... can you please try to reproduce and send the output? Please try both 32bit and 64bit, as I see 32bit is the one that failing for you. Once I will be able to reproduce this locally, I can provide a fix, however, it does not make sense that the date simply changes... Thanks!
gcc testtime.c && ./a.out TZ=(null) 0=IST 1=GMT timezone=-3600 daylight=1 tm_isdst= 0, tm_yday= 0, tm_wday= 0, 0100-10-10 00:00:00 tm_isdst= 1, tm_yday=313, tm_wday= 4, 0100-10-09 23:00:00 gcc -m32 testtime.c && ./a.out TZ=(null) 0=IST 1=GMT timezone=-3600 daylight=1 tm_isdst= 0, tm_yday= 0, tm_wday= 0, 0100-10-10 00:00:00 tm_isdst= 1, tm_yday=313, tm_wday= 4, 0100-10-09 23:00:00 Given that, I don't know why the test passes on 64...
OK, this is actually a p11-kit bug... good you found it. Can you please test this[1] patch? Thanks! [1] https://github.com/p11-glue/p11-kit/pull/236/files
The test has passed on 0.23.12, thanks
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a252cace3c34490668017794a229f6ddf6a3f7d8 commit a252cace3c34490668017794a229f6ddf6a3f7d8 Author: Alon Bar-Lev <alonbl@gentoo.org> AuthorDate: 2019-07-02 05:50:20 +0000 Commit: Alon Bar-Lev <alonbl@gentoo.org> CommitDate: 2019-07-02 05:50:56 +0000 app-crypt/p11-kit: fix date handling Closes: https://bugs.gentoo.org/show_bug.cgi?id=688460 Thanks: Alexey Signed-off-by: Alon Bar-Lev <alonbl@gentoo.org> Package-Manager: Portage-2.3.66, Repoman-2.3.11 RepoMan-Options: --force .../p11-kit/files/p11-kit-0.23.12-mktime.patch | 26 ++++++++++++++++++++++ ...it-0.23.12.ebuild => p11-kit-0.23.12-r1.ebuild} | 4 ++++ ....23.16.1.ebuild => p11-kit-0.23.16.1-r1.ebuild} | 4 ++++ 3 files changed, 34 insertions(+)
