Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 687726 - sys-process/psmisc makes all errors during emake of peekdf nonfatal due to old hack
Summary: sys-process/psmisc makes all errors during emake of peekdf nonfatal due to ol...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2019-06-09 15:53 UTC by tt_1
Modified: 2019-10-26 11:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tt_1 2019-06-09 15:53:25 UTC
This has undesireable side effects, that result in a broken binary and also stage3's if there is a compile error going on. This is the case for musl at the moment, but there might be other arches affected. 

The reason for this fix are related to bug #330631, they have been solved by upstream recently. 

this must go, leaving only emake: 


src_compile() {
	# peekfd is a fragile crap hack #330631
	nonfatal emake -C src peekfd || touch src/peekfd{.o,}
	emake
}


and this too, as it removes peekfd regardless of errors: 

[[ -s ${ED%/}/usr/bin/peekfd ]] || rm -f "${ED%/}"/usr/bin/peekfd
[[ -e ${ED%/}/usr/bin/peekfd ]] || rm -f "${ED%/}"/usr/share/man/man1/peekfd.1
Comment 1 tt_1 2019-06-09 15:55:25 UTC
this is the fix for old hack: 

https://gitlab.com/psmisc/psmisc/commit/d14bc4620a59e2d9a162611e6f1d922487f9c8ed