Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 68671 - mirrorselect dumps binary to screen in deep scan mode.
Summary: mirrorselect dumps binary to screen in deep scan mode.
Status: VERIFIED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: John Mylchreest (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-23 19:24 UTC by Dan Egli
Modified: 2004-11-07 08:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Egli 2004-10-23 19:24:33 UTC
run the following command:

mirrorselect -a -D

Watch your screen fill with garbage! now run it again without the -D,
notice it works and updates your make.conf correctly?



Reproducible: Always
Steps to Reproduce:
1. given above
2.
3.

Actual Results:  
raw binary data dumped to screen with no formatting or control escaping.


Expected Results:  
redirect the downloaded data to /dev/null or to a file on the file system.
Comment 1 Timothy Miller 2004-11-02 19:35:32 UTC
I want to second this.  I expect some people will attempt to use -D and also >> to their make.conf file and end up filling the file with garbage.

^N and ^O are control codes which cause character set changing on the display, making it impossible to read the text.  When I used -D, those codes appeared in the garbage displayed, resulting in unreadable hostnames when it finished.

Also consider what can happen with the escape character, depending on what follows it.
Comment 2 John Mylchreest (RETIRED) gentoo-dev 2004-11-03 12:35:49 UTC
this works fine for me.
what version of mirrorselect?
Comment 3 Dan Egli 2004-11-03 13:06:06 UTC
I show version 0.84. 

Observe (piped through LESS to observe first few lines before garbage appears):

mars root # mirrorselect -a -D 2>&1 | less
Downloading a list of mirrors...
Removing IPV6 Only Servers...
Downloading 100k segments from 150 server(s)

       Testing: http://gentoo.osuosl.org/^M[0%]^M# $<E4><FE><A4>^Yl<C9>$<A7>1]

mars root # mirrorselect -v
Mirrorselect version: 0.84
Comment 4 John Mylchreest (RETIRED) gentoo-dev 2004-11-07 04:10:57 UTC
this was fixed in 0.86.
this has now been pushed into stable
Comment 5 Dan Egli 2004-11-07 08:25:01 UTC
just tested new version. Does seem to work. mirrorselect -a -D -s5 does not show any garbage.

Comment 6 John Mylchreest (RETIRED) gentoo-dev 2004-11-07 08:45:57 UTC
closing bug.
thanks for verifying.