Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 68669 - mail-filter/dspam: Don't use --enable-spam-subject
Summary: mail-filter/dspam: Don't use --enable-spam-subject
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Net-Mail Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-23 18:34 UTC by Alexander Gretencord
Modified: 2005-01-09 07:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Gretencord 2004-10-23 18:34:59 UTC
If you use this configure option you can't get around it, not even when a user specifies otherwise in his personal preferences, because this code snippet is used to decide whether or not to use the subject tag:

from dspam.c:

#ifdef SPAM_SUBJECT
            do_tag = 1;
#endif
            if (PTX != NULL               &&
                PTX->spam_mode == DPS_TAG &&
                PTX->spam_subject[0] != 0)
              do_tag = 1;

            if (do_tag) {
...

So as you can see, if you enable it through configure, you have no chance of getting do_tag=0.

Also you can not get around this by setting the subject prefix to a blank string because of this:

            if (do_tag) {
                char spam_subject[16];
                long subject_length;
                strcpy(spam_subject, "[SPAM]");
                if (PTX != NULL && PTX->spam_mode == DPS_TAG)
                  strcpy(spam_subject, PTX->spam_subject);

I want choice! Please remove this configure option, tagging the subject works without it.
Comment 1 Tuan Van (RETIRED) gentoo-dev 2004-10-23 21:16:39 UTC
Just a guess, this bug is for mail-filter/dspam?
Comment 2 Nick Dimiduk (RETIRED) gentoo-dev 2004-10-24 07:35:40 UTC
Alexander, what package is this bug filed against?
Comment 3 Alexander Gretencord 2004-10-24 07:43:06 UTC
All, although the lines from dspam.c come from the 3.0.0 release. The whole code for handling the tagging is new in 3.2.0.
Comment 4 Alexander Gretencord 2004-10-24 07:45:47 UTC
Oh, hey I just saw this, LOL, yes of course, mail-filter/dspam. Mental note to self: Don't file bug reports in the middle of the night, when you had a good time drinking beer at an old castle before :)
Comment 5 Lim Swee Tat (RETIRED) gentoo-dev 2004-11-14 21:59:55 UTC
?? so what should I be doing with this??
Comment 6 Alexander Gretencord 2004-11-15 02:11:35 UTC
What part of "Please remove this configure option, tagging the subject works without it." did you not see? :)
Comment 7 Lim Swee Tat (RETIRED) gentoo-dev 2005-01-09 07:04:15 UTC
ok... will fix in CVS.