686352 – savedconfig.eclass: Documentation of arguments of restore_config() does not match implementation

Bug 686352 - savedconfig.eclass: Documentation of arguments of restore_config() does not match implementation

Summary: savedconfig.eclass: Documentation of arguments of restore_config() does not m...

Status:	CONFIRMED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All All

Importance:	Normal normal
Assignee:	Gentoo's Team for Core System packages

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2019-05-20 00:52 UTC by Arfrever Frehtes Taifersar Arahesis
Modified:	2019-05-20 00:52 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Arfrever Frehtes Taifersar Arahesis 2019-05-20 00:52:10 UTC

Documentation of arguments of restore_config() implies that multiple arguments are supported.

In reality:

- If configuration file scheme (e.g. ${PORTAGE_CONFIGROOT}/etc/portage/savedconfig/${CATEGORY}/${PF}) is a regular file, then only the first argument of restore_config() is actually used.

- If configuration file scheme (e.g. ${PORTAGE_CONFIGROOT}/etc/portage/savedconfig/${CATEGORY}/${PF}) is a directory, then no arguments are actually used, except that the first argument is mistakenly used in die() message.
Contents of this directory are copied to ${PWD}, not $1, but if copying fails then die() message mentions $1.