Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 68568 - strip-flags in app-editors/emacs-cvs-21.3.50-r1 does nothing
Summary: strip-flags in app-editors/emacs-cvs-21.3.50-r1 does nothing
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Emacs project
URL:
Whiteboard:
Keywords: Inclusion
: 76875 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-10-22 09:56 UTC by Matthew Kennedy (RETIRED)
Modified: 2006-08-10 23:25 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Kennedy (RETIRED) gentoo-dev 2004-10-22 09:56:35 UTC
On two ~x86 machines, strip-flags does nothing.  I have to manually
prefix emerge with CFLAGS='' and run it like this:

    CLFAGS='' emerge emacs-cvs

It is important that we remove flags for emacs-cvs.  Without stripping
the CFLAGS, emacs-cvs doesn't get past bootstrap for certain flags.
Comment 1 Mamoru KOMACHI (RETIRED) gentoo-dev 2004-10-22 22:30:07 UTC
On ~x86 machines, strip-flags allows stable flags, "-O -O1 -O2 
-mcpu -march -mtune -fstack-protector -pipe -g" plus unstable
flags, "-Os -O3 -freorder-blocks -fprefetch-loop-arrays"
 (and arch specific flags needed for that arch to compile things 
correctly). If we need to remove flags listed above, we should
use filter-flags to disable the flags explicitly.
Comment 2 Matthew Kennedy (RETIRED) gentoo-dev 2004-11-04 15:42:33 UTC
I think we should be using a filter which removes any flags which interfere with debugging, especially given thats its a cvs port.  Any suggestions?
Comment 3 Mamoru KOMACHI (RETIRED) gentoo-dev 2004-11-07 05:28:24 UTC
In general I agree with the idea, given that per package
CFLAGS setting is not available at the moment. If per
package CFLAGS is supported by Portage, I would
rather leave CFLAGS to users than filter except
some of them known to cause problem. Some users
may want to try emacs-cvs package not for helping
development but for using newer version of Emacs,
as <=emacs-21.3 has bad Unicode support, no
GTK+, etc.

However, I'm not strongly against removing any flags
which interfer with debugging. What do other people
say about it?
Comment 4 Matthew Kennedy (RETIRED) gentoo-dev 2005-01-06 07:58:07 UTC
*** Bug 76875 has been marked as a duplicate of this bug. ***
Comment 5 Timothy Stotts 2006-07-08 16:02:27 UTC
I think that the emacs-cvs ebuild should focus on performance rather than debugging, unless a USE flag is present, such as 'debug', or something similar.

A lot of developers use Emacs as their primary editor, but couldn't care less about firing up gdb to debug the emacs application. And likewise, emacs 21.x is missing a lot of essential features, even more Unicode and GTK+.

I know for myself, I run emacs-cvs more than any other application on my systems (except maybe screen and rxvt).
Comment 6 Matthew Kennedy (RETIRED) gentoo-dev 2006-08-10 23:25:27 UTC
I've started adding appropriate CFLAG munging to the ebuild.  So far -O3 has been caught with replace-flags.