Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 684888 - xdg.eclass: updates desktop database unnecessarily when .desktop files do not specify MimeType=
Summary: xdg.eclass: updates desktop database unnecessarily when .desktop files do not...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Freedesktop bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-01 17:20 UTC by Michał Górny
Modified: 2019-05-01 17:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-05-01 17:20:47 UTC 
Per update-desktop-database(1), the database is only a cache of MIME types handled by desktop files.  Therefore, updating it is only necessary if .desktop files specify MimeType=.  However, the eclass updates them based on mere presence of .desktop files which is wrong.
Comment 1 Mike Gilbert gentoo-dev 2019-05-01 17:35:38 UTC 
Given that the eclass does not check the content of the files at all, it is probably better to call update-desktop-database than not.

Checking the file content before calling it would be an enhancement, not a bug fix.