684016 – sys-fs/lvm2: USE=-udev still has `need udev` in OpenRC init script

Bug 684016 - sys-fs/lvm2: USE=-udev still has `need udev` in OpenRC init script

Summary: sys-fs/lvm2: USE=-udev still has `need udev` in OpenRC init script

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Robin Johnson

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2019-04-21 18:58 UTC by Piotr Karbowski (RETIRED)
Modified:	2019-05-08 20:28 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Piotr Karbowski (RETIRED) gentoo-dev

2019-04-21 18:58:13 UTC

Hi,

It appears that lvm init script now have `need udev`. Even when built with USE=-udev. Here it complain that I have no udev init script at all.

Perhaps changing that to `after udev` or `use udev` would be better?

Comment 1 Robin Johnson archtester

2019-04-21 19:47:04 UTC

`use udev`/`after udev` wouldn't be strong enough I think.

If built with USE=udev, then trying to start lvm2 SHOULD start udev (and block until it's up).

That said, I don't see a generally valid case where users would be flipping between USE=udev/-udev, so making the init script be conditional (either sed/patch at instal or via conf.d) would probably be ok.

Comment 2 Piotr Karbowski (RETIRED) gentoo-dev

2019-05-08 20:28:07 UTC

Fixed in following commit

commit 26a0538c6aa1a45c47d3a8b38e55a11516184359
Author: Robin H. Johnson <robbat2@gentoo.org>
Date:   2019-05-07 12:16:10 -0700

    sys-fs/lvm2: better USE=-udev init support
    
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>