Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 682870 - dev-python/pycairo-1.17.0-r1 fails test with pypy3: "undefined symbol: PyOS_FSPath"
Summary: dev-python/pycairo-1.17.0-r1 fails test with pypy3: "undefined symbol: PyOS_F...
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Python Gentoo Team
URL: https://github.com/pygobject/pycairo/...
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2019-04-08 10:45 UTC by Paolo Pedroni
Modified: 2019-04-15 14:33 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
pycairo-1.17.0-r1:20190408-101131.log.gz (pycairo-1.17.0-r1:20190408-101131.log.gz,22.59 KB, application/gzip)
2019-04-08 10:45 UTC, Paolo Pedroni
Details
pycairo-1.7.0-r1-dont-use-PyOS_FSPath-with-pypy3.6.patch (pycairo-1.7.0-r1-dont-use-PyOS_FSPath-with-pypy3.6.patch,952 bytes, patch)
2019-04-08 11:27 UTC, Paolo Pedroni
Details | Diff
pycairo-1.17.0-r1:20190408-103516.log.gz (pycairo-1.17.0-r1:20190408-103516.log.gz,25.80 KB, application/gzip)
2019-04-08 11:31 UTC, Paolo Pedroni
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paolo Pedroni 2019-04-08 10:45:47 UTC
Created attachment 572222 [details]
pycairo-1.17.0-r1:20190408-101131.log.gz

* pypy3: running distutils-r1_run_phase python_test
pypy3 setup.py test
running test
copying /var/tmp/portage/dev-python/pycairo-1.17.0-r1/work/pycairo-1.17.0-pypy3/lib/cairo/_cairo.pypy3-71-x86_64-linux-gnu.so -> cai
ro
Traceback (most recent call last):
  File "setup.py", line 600, in <module>
    main()
  File "setup.py", line 595, in main
    cmdclass=cmdclass,
  File "/usr/lib/pypy3.6/site-packages/setuptools/__init__.py", line 145, in setup
    return distutils.core.setup(**attrs)
  File "/usr/lib/pypy3.6/lib-python/3/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/usr/lib/pypy3.6/lib-python/3/distutils/dist.py", line 955, in run_commands
    self.run_command(cmd)
  File "/usr/lib/pypy3.6/lib-python/3/distutils/dist.py", line 974, in run_command
    cmd_obj.run()
  File "setup.py", line 260, in run
    cmd.run()
  File "setup.py", line 194, in run
    import cairo
  File "/var/tmp/portage/dev-python/pycairo-1.17.0-r1/work/pycairo-1.17.0/cairo/__init__.py", line 1, in <module>
    from ._cairo import *  # noqa: F401,F403
ImportError: /var/tmp/portage/dev-python/pycairo-1.17.0-r1/work/pycairo-1.17.0/cairo/_cairo.pypy3-71-x86_64-linux-gnu.so: undefined symbol: PyOS_FSPath

This is due to pypy-3.6 not implementing PyOS_FSPath().

There is a patch on pycairo github (https://github.com/pygobject/pycairo/commit/e616e810fc3317e0b91d0b8cef52875a112d4e39) implementing a workaround.

# emerge --info =dev-python/pycairo-1.17.0-r1
Portage 2.3.62 (python 3.6.5-final-0, default/linux/amd64/17.1/desktop, gcc-8.3.0, glibc-2.28-r5, 4.19.27-gentoo-r1 x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.19.27-gentoo-r1-x86_64-AMD_Phenom-tm-_II_X4_965_Processor-with-gentoo-2.6
KiB Mem:    12264780 total,    692012 free
KiB Swap:    8351740 total,   8294908 free
Timestamp of repository gentoo: Tue, 02 Apr 2019 07:45:01 +0000
Head commit of repository gentoo: c872570bcbd3f5ced8dd703fda783a1120a06e49
sh dash 0.5.9.1-r3
ld GNU gold (Gentoo 2.30 p5 2.30.0) 1.15
distcc 3.3.2 x86_64-pc-linux-gnu [enabled]
ccache version 3.3.4 [disabled]
app-shells/bash:          4.4_p23-r1::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.26.2::gentoo
dev-lang/python:          2.7.15::gentoo, 3.6.5::gentoo
dev-util/ccache:          3.3.4-r1::gentoo
dev-util/cmake:           3.9.6::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.16.1-r1::gentoo
sys-devel/binutils:       2.30-r4::gentoo
sys-devel/gcc:            8.3.0::gentoo
sys-devel/gcc-config:     2.0::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 4.17::gentoo (virtual/os-headers)
sys-libs/glibc:           2.28-r5::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.europe.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-max-age: 24
    sync-rsync-extra-opts: 
    sync-rsync-verify-metamanifest: yes

x-portage
    location: /usr/local/portage
    masters: gentoo
    priority: 0

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -frecord-gcc-switches -march=amdfam10 -flto=5"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -frecord-gcc-switches -march=amdfam10 -flto=5"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going y --with-bdeps y"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe -frecord-gcc-switches -march=amdfam10 -flto=5"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs cgroup compress-build-logs config-protect-if-modified distcc distlocks ebuild-locks ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned sandbox sfperms split-elog split-log strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -frecord-gcc-switches -march=amdfam10 -flto=5"
GENTOO_MIRRORS="http://gentoo.modulix.net/gentoo/ http://mirror.netcologne.de/gentoo/ http://ftp.halifax.rwth-aachen.de/gentoo/ http://mirrors.evowise.com/gentoo/ http://gentoo.mirrors.ovh.net/gentoo-distfiles/"
LANG="it_IT.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -Wl,--sort-common -flto=5"
LINGUAS="it it_IT"
MAKEOPTS="-j15 -l4"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="3dnow X a52 aac aalib acl acpi alsa amd64 ao audiofile bash-completion bluetooth branding bzip2 cairo caps cdda cddb cdparanoia cdr cli consolekit crypt css cups curl cxx dbus dga djvu dri dts dvd dvdr emboss encode exif expat fbcon ffmpeg fftw flac fontconfig fortran ftp gd gdbm gif glamor gmp gnutls gpm graphviz gtk iconv icu idn ieee1394 imagemagick imlib inotify introspection ipv6 java jbig jpeg jpeg2k kde lame lcms libass libcaca libnotify libsamplerate libtirpc lm_sensors lua lzma lzo mad mmap mng mp3 mp4 mpeg mplayer multilib musicbrainz ncurses nls nptl nsplugin offensive ogg openal opengl openmp pam pango pcre pdf png policykit postscript ppds pulseaudio qt5 rdesktop readline samba sctp sdl seccomp sndfile speex spell sqlite ssl startup-notification svg symlink syslog systemd taglib test theora threads tiff truetype udev udisks unicode upower usb vaapi vcd vdpau vim-syntax vorbis wavpack wayland win32codecs wmf wxwidgets x264 xattr xcb xcomposite xine xinerama xml xpm xscreensaver xv xvid zlib" ABI_X86="64" ALSA_CARDS="hda-intel virmidi" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" CAMERAS="kodak ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="3dnow 3dnowext mmx mmxext popcnt sse sse2 sse3 sse4a" CURL_SSL="gnutls" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="pc" INPUT_DEVICES="libinput" KERNEL="linux" L10N="it en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" NETBEANS_MODULES="apisupport cnd groovy gsf harness ide identity j2ee java mobility nb php profiler soa visualweb webcommon websvccommon xml" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-1" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6 pypy pypy3" RUBY_TARGETS="ruby23" USERLAND="GNU" VIDEO_CARDS="radeon r600" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

dev-python/pycairo-1.17.0-r1::gentoo was built with the following:
USE="-doc -examples -test" ABI_X86="(64)" PYTHON_TARGETS="pypy pypy3 python2_7 python3_6 -python3_5 (-python3_7)"

# emerge -1pqv =dev-python/pycairo-1.17.0-r1
[ebuild   R   ] dev-python/pycairo-1.17.0-r1  USE="test* -doc -examples" PYTHON_TARGETS="pypy pypy3 python2_7 python3_6 -python3_5 (-python3_7)"
Comment 1 Paolo Pedroni 2019-04-08 11:27:19 UTC
Created attachment 572224 [details, diff]
pycairo-1.7.0-r1-dont-use-PyOS_FSPath-with-pypy3.6.patch

Signed-off-by: Paolo Pedroni <paolo.pedroni@iol.it>
Comment 2 Paolo Pedroni 2019-04-08 11:31:45 UTC
Created attachment 572226 [details]
pycairo-1.17.0-r1:20190408-103516.log.gz
Comment 3 Paolo Pedroni 2019-04-08 11:33:12 UTC
With the patch above tests build fine, but then one fails:
======================================================= test session starts ========================================================
platform linux -- Python 3.6.1[pypy-7.1.0-beta], pytest-3.10.1, py-1.5.4, pluggy-0.7.1
rootdir: /var/tmp/portage/dev-python/pycairo-1.17.0-r1/work/pycairo-1.17.0, inifile:
plugins: virtualenv-1.2.11, shutil-1.2.11, hypothesis-3.59.1, flaky-3.1.1
collected 263 items / 3 skipped

tests/test_api.py ...............s.                                                                                          [  6%]
tests/test_cmod.py .                                                                                                         [  6%]
tests/test_context.py .......s.............................s.....................s......                                     [ 31%]
tests/test_device.py ...........                                                                                             [ 36%]
tests/test_enums.py s......                                                                                                  [ 38%]
tests/test_error.py ....                                                                                                     [ 40%]
tests/test_font.py ...............s.s...........                                                                             [ 51%]
tests/test_glyph.py ..                                                                                                       [ 52%]
tests/test_hypothesis.py F..........                                                                                         [ 56%]
tests/test_matrix.py ...........                                                                                             [ 60%]
tests/test_path.py ....                                                                                                      [ 61%]
tests/test_pattern.py ..............................                                                                         [ 73%]
tests/test_rectangle.py ...                                                                                                  [ 74%]
tests/test_region.py ...........                                                                                             [ 78%]
tests/test_surface.py ......s..........................s...................                                                  [ 98%]
tests/test_textcluster.py .                                                                                                  [ 99%]
tests/test_textextents.py ..                                                                                                 [100%]

============================================================= FAILURES =============================================================
___________________________________________________________ test_fspaths ___________________________________________________________

tempdir_path = '/var/tmp/portage/dev-python/pycairo-1.17.0-r1/temp/tmpfy1el2ay'
path = <tests.hypothesis_fspaths._PathLike object at 0x00007f9a8aa6ce90>

    @given(path=fspaths())
    @settings(max_examples=500)
    def test_fspaths(tempdir_path, path):
        p = _to_temp_path(tempdir_path, path)
    
        assert not os.listdir(tempdir_path)
        # filter out "."
        if os.path.exists(p):
            return
    
        if cairo_ver() >= (1, 15, 10):
            def path_encode(p):
                return p.encode("utf-8")
        else:
            def path_encode(p):
                new = temp.encode("mbcs")
                if new.decode("mbcs") != p:
                    raise ValueError
                return new
    
        # cairo up to 1.15.8 uses fopen, which only supports ANSI paths under
        # Windows. 1.15.10+ uses utf-8 like glib.
        is_valid = True
        if os.name == "nt":
            temp = os.path.join(p)
            if isinstance(temp, type(b"")):
                if sys.version_info[0] == 3:
                    temp = os.fsdecode(temp)
                else:
                    temp = temp.decode(sys.getfilesystemencoding(), "strict")
            if isinstance(temp, type(u"")):
                try:
                    path_encode(temp)
                except ValueError:
                    is_valid = False
    
        surface = cairo.ImageSurface(cairo.FORMAT_ARGB32, 10, 10)
        try:
>           surface.write_to_png(p)
E           TypeError: Surface.write_to_png takes one argument which must be a filename, file object, or a file-like object which has a "write" method (like StringIO)

tests/test_hypothesis.py:80: TypeError

During handling of the above exception, another exception occurred:

tempdir_path = '/var/tmp/portage/dev-python/pycairo-1.17.0-r1/temp/tmpfy1el2ay'

    @given(path=fspaths())
>   @settings(max_examples=500)
    def test_fspaths(tempdir_path, path):

tests/test_hypothesis.py:43: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/usr/lib/pypy3.6/site-packages/hypothesis/core.py:587: in execute
    result = self.test_runner(data, run)
/usr/lib/pypy3.6/site-packages/hypothesis/executors.py:58: in default_new_style_executor
    return function(data)
/usr/lib/pypy3.6/site-packages/hypothesis/core.py:578: in run
    return test(*args, **kwargs)
tests/test_hypothesis.py:43: in test_fspaths
    @settings(max_examples=500)
/usr/lib/pypy3.6/site-packages/hypothesis/core.py:525: in test
    result = self.test(*args, **kwargs)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

tempdir_path = '/var/tmp/portage/dev-python/pycairo-1.17.0-r1/temp/tmpfy1el2ay'
path = <tests.hypothesis_fspaths._PathLike object at 0x00007f9a8aa6ce90>

    @given(path=fspaths())
    @settings(max_examples=500)
    def test_fspaths(tempdir_path, path):
        p = _to_temp_path(tempdir_path, path)
    
        assert not os.listdir(tempdir_path)
        # filter out "."
        if os.path.exists(p):
            return
    
        if cairo_ver() >= (1, 15, 10):
            def path_encode(p):
                return p.encode("utf-8")
        else:
            def path_encode(p):
                new = temp.encode("mbcs")
                if new.decode("mbcs") != p:
                    raise ValueError
                return new
    
        # cairo up to 1.15.8 uses fopen, which only supports ANSI paths under
        # Windows. 1.15.10+ uses utf-8 like glib.
        is_valid = True
        if os.name == "nt":
            temp = os.path.join(p)
            if isinstance(temp, type(b"")):
                if sys.version_info[0] == 3:
                    temp = os.fsdecode(temp)
                else:
                    temp = temp.decode(sys.getfilesystemencoding(), "strict")
            if isinstance(temp, type(u"")):
                try:
                    path_encode(temp)
                except ValueError:
                    is_valid = False
    
        surface = cairo.ImageSurface(cairo.FORMAT_ARGB32, 10, 10)
        try:
            surface.write_to_png(p)
        except (TypeError, ValueError):
>           assert not is_valid
E           assert not True

tests/test_hypothesis.py:82: AssertionError
------------------------------------------------------------ Hypothesis ------------------------------------------------------------
Falsifying example: test_fspaths(tempdir_path='/var/tmp/portage/dev-python/pycairo-1.17.0-r1/temp/tmpfy1el2ay', path=<tests.hypothesis_fspaths._PathLike at 0x7f9a8aa6ce90>)

You can reproduce this example by temporarily adding @reproduce_failure('3.59.1', b'AAAAAAABAAABAQ==') as a decorator on your test case
===Flaky Test Report===


===End Flaky Test Report===
======================================== 1 failed, 253 passed, 12 skipped in 11.34 seconds =========================================