Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 682328 - mail-filter/opendkim: upstream init system files
Summary: mail-filter/opendkim: upstream init system files
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ralph Seichter
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-02 14:56 UTC by Michael Orlitzky
Modified: 2019-04-24 12:55 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Orlitzky gentoo-dev 2019-04-02 14:56:22 UTC
This is a nice big mess =)

So, upstream already has its own systemd service file. We should be trying to fix that, instead of maintaining our own separate copy. Ours is buggy (bug 606978), but the upstream one is too. They do things like specify type=Forking and then set a PID file, username, and group -- which doesn't make any sense.

Our OpenRC service script is also cross-platform, and should be upstreamed. Reference: "Upstream your service scripts", in https://github.com/OpenRC/openrc/blob/master/service-script-guide.md

That way we can take the $command and socket directory from the build system, and share it with systemd.
Comment 1 Ralph Seichter 2019-04-02 17:24:31 UTC
I have opened https://github.com/trusteddomainproject/OpenDKIM/pull/41 to get our OpenRC service script added.
Comment 2 Michael Orlitzky gentoo-dev 2019-04-24 12:55:43 UTC
There's nothing left to do here. We'll hear back soon about whether or not the systemd stuff works, and then we just have to pester upstream on your pull request until we get a response =)

Thanks for all your work.