681984 – net-libs/grpc: <grpc++/grpc++.h> missing (?)

Bug 681984 - net-libs/grpc: <grpc++/grpc++.h> missing (?)

Summary: net-libs/grpc: <grpc++/grpc++.h> missing (?)

Status:	RESOLVED UPSTREAM

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Jason Zaman

URL:	https://github.com/draios/sysdig/pull...
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2019-03-29 08:56 UTC by Michał Górny
Modified:	2021-06-21 23:42 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2019-03-29 08:56:24 UTC

dev-util/sysdig started requiring net-libs/grpc.  However, it fails to build (after fixing all the other upstream silliness) with the following error:

[3/9] Building CXX object userspace/libsinsp/CMakeFiles/sinsp.dir/cri.cpp.o
FAILED: userspace/libsinsp/CMakeFiles/sinsp.dir/cri.cpp.o 
/usr/bin/c++  -DHAS_CAPTURE -DK8S_DISABLE_THREAD -DPLATFORM_NAME=\"Linux\" -I../userspace/libsinsp/. -I../userspace/libsinsp/../../common -I../userspace/libsinsp/../libscap -I/usr/include/jsoncpp -I/usr/include/luajit-2.0 -I/usr/include/tbb -Iuserspace/libsinsp -Wall -ggdb -std=c++0x -O3 -fno-strict-aliasing -DNDEBUG -MD -MT userspace/libsinsp/CMakeFiles/sinsp.dir/cri.cpp.o -MF userspace/libsinsp/CMakeFiles/sinsp.dir/cri.cpp.o.d -o userspace/libsinsp/CMakeFiles/sinsp.dir/cri.cpp.o -c ../userspace/libsinsp/cri.cpp
../userspace/libsinsp/cri.cpp:23:10: fatal error: grpc++/grpc++.h: No such file or directory
 #include <grpc++/grpc++.h>
          ^~~~~~~~~~~~~~~~~


It seems that we're installing grpc++/impl alongside grpcpp/impl but not other files from grpcpp tree.  I think we should either settle on not installing grpc++ tree at all, or install it completely usable.

Comment 1 Jason Zaman gentoo-dev

2019-03-29 09:25:37 UTC

Hm, how long ago is sysdig from?

https://github.com/grpc/grpc/pull/14210
https://github.com/grpc/grpc/commit/0e00c430827e81d61e1e7164ef04ca21ccbfaa77 

says <grpc++/grpc++h> was deprecated and moved to <grpcpp/grpcpp.h> since v1.10.0 (a bit over a year ago).

Looks like they should already be added tho:
https://github.com/grpc/grpc/blob/206592ce9c104e95cf699e81d20c3cadbf1f4d1a/Makefile#L5287


I'm definitely not opposed to adding the other stub files in grpc++/ but the other option is to patch sysdig since nothing else appears to have complained so far.

Comment 2 Michał Górny archtester

2019-03-29 09:38:56 UTC

Ok, thanks.  I've submitted a patch for sysdig already.  It's a fresh release but I see they're normally building against bundled 1.8.1...

Comment 3 luzpaz 2019-06-24 21:11:11 UTC

Is this still an issue?

Comment 4 Michał Górny archtester

2019-06-25 06:10:38 UTC

(In reply to kunda from comment #3)
> Is this still an issue?

Upstream has merged my PR but there hasn't been a release with it yet.

Comment 5 Georgy Yakovlev archtester

2020-10-09 23:29:51 UTC

I see no patches in tree anymore, looks like this can be closed?

Comment 6 Georgy Yakovlev archtester

2021-06-21 23:42:43 UTC

checked upstream, both versions we have in tree contain fixes.
closing.