681882 – media-libs/x264 - add USE=lto

Bug 681882 - media-libs/x264 - add USE=lto

Summary: media-libs/x264 - add USE=lto

Status:	RESOLVED WONTFIX

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Gentoo Media-video project

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	lto
	Show dependency tree

Reported:	2019-03-27 21:26 UTC by Alec Ari
Modified:	2024-05-17 04:15 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alec Ari 2019-03-27 21:26:34 UTC

media-libs/x264 is missing an option for lto.

One more thing, the git repository has changed from:

https://git.videolan.org/git/x264.git

to:

https://code.videolan.org/videolan/x264.git

While the git.videolan.org mirror may still work, it being obsoleted.

Thanks!

Comment 1 Michael Cook 2024-02-01 01:21:41 UTC

I just added filter-lto and added $(usex lto "--enable-lto" "") to the configure script bit. This does call filter-lto multiple times, which I don't think it strictly necessary. The configure flag seems to just pass -flto=auto when it's set, so unless we patch it, we don't need to handle whatever the user might want to use in their CFLAGS ...


This seems to work

Comment 2 Eli Schwartz gentoo-dev

2024-03-11 21:03:24 UTC

What's the advantage of this over just putting -flto into your make.conf COMMON_FLAGS?

Comment 3 Eli Schwartz gentoo-dev

2024-05-17 04:15:53 UTC

I'm assuming there is no reason, then. Easy enough.