Created attachment 570908 [details, diff] flameshot-0.6.0.diff Attached is an ebuild for lupoDharkael's Flameshot screenshot application (version 0.6.0). Flameshot is a powerful, simple, customizable screenshot application written in C++ using Qt. As such, it depends on the base Qt libraries. It is licensed under the GNU General Public License version 3 or higher. The appropriate place for this package is most likely media-gfx. - Ryan El Kochta P.S. this is my first time doing this, so if I'm doing something wrong, please let me know :-)
Created attachment 570948 [details, diff] flameshot-0.6.0.diff
Created new ebuild with GCC version check (flameshot-0.6.0-r1.ebuild).
Hey, it's become quite rare to merge ebuilds from bugzilla. You'd have more success by filing a PR in Github, which you can then link to close this bug. You need to add a metadata.xml file with someone from Gentoo to commit for you. If you don't have a dedicated developer to commit for you, it's most likely going to be the proxy-maint project. Check examples from ebuilds in the tree how it's added to a metadata.xml file. https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers https://wiki.gentoo.org/wiki/Gentoo_GitHub Then, about your ebuild. You should use xdg-utils.eclass with EAPI-7 instead of gnome2-utils.eclass to do the icon_cache_update. It's called xdg_icon_cache_update. I don't think the gnome2_icon_cache_update even works with EAPI-7, did you test this? With EAPI-6 you should still use gnome2_icon_cache_update. Then your GCC check is a bit wrong, because $(gcc-version) returns a string, and it only returns the major.minor version. For this one you should use "$(gcc-fullversion) -lt 4.9.2" Good luck :)
(In reply to Joonas Niilola from comment #3) > Hey, > > it's become quite rare to merge ebuilds from bugzilla. You'd have more > success by filing a PR in Github, which you can then link to close this bug. > > You need to add a metadata.xml file with someone from Gentoo to commit for > you. If you don't have a dedicated developer to commit for you, it's most > likely going to be the proxy-maint project. Check examples from ebuilds in > the tree how it's added to a metadata.xml file. > > https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers > https://wiki.gentoo.org/wiki/Gentoo_GitHub > > Then, about your ebuild. You should use xdg-utils.eclass with EAPI-7 instead > of gnome2-utils.eclass to do the icon_cache_update. It's called > xdg_icon_cache_update. I don't think the gnome2_icon_cache_update even works > with EAPI-7, did you test this? With EAPI-6 you should still use > gnome2_icon_cache_update. > > Then your GCC check is a bit wrong, because $(gcc-version) returns a string, > and it only returns the major.minor version. For this one you should use > "$(gcc-fullversion) -lt 4.9.2" > > Good luck :) Thank you for the advice - it is very much appreciated. I have followed your committing advice and opened a PR (https://github.com/gentoo/gentoo/pull/11539). I have also addressed the issues you mentioned about the ebuild, and cleaned up some unset variables. It now uses xdg-utils and gcc-fullversion. Thanks again!
Added. commit c8519f723d963b46b3ff2137d9ac7d498af94a57 (HEAD -> master, origin/master) Author: Pavel Kalugin <38429428+pavel-the-best@users.noreply.github.com> Date: Mon May 25 21:48:18 2020 +0300 media-gfx/flameshot: new package Signed-off-by: Pavel Kalugin <paul.kalug@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/15968 Signed-off-by: Maxim Koltsov <maksbotan@gentoo.org>
