Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 679592 - sys-kernel/gentoo-sources - Remove 5011_enable-cpu-optimizations-for-gcc8.patch and 5010_enable-additional-cpu-optimizations-for-gcc-4.9.patch
Summary: sys-kernel/gentoo-sources - Remove 5011_enable-cpu-optimizations-for-gcc8.pat...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-06 14:25 UTC by LABBE Corentin
Modified: 2019-03-06 15:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description LABBE Corentin 2019-03-06 14:25:32 UTC
Hello                                                                           
                                                                                
The origin of this bugreport is when I tried to work on CI the gentoo kernel and
applying patch from https://github.com/gentoo/linux-patches.git                 
                                                                                
One patch always fail to apply:                                                 
5011_enable-cpu-optimizations-for-gcc8.patch                                    
                                                                                
When working on why it always fail I see that 5010_enable-additional-cpu-optimizations-for-gcc-4.9.patch
is near the same.                                                               
                                                                                
Furthermore, I just saw that theses patchs are only used in specific condition by eclass/kernel-2.
                                                                                
This situation lead to many problems:                                           
1) first those two patch are out of tree for a long time and upstream will never merge them.
I have tried to send a part (only the more cpu part) of it upstream, but I think the chance to get them merged is 0.
                                                                                
2) Adding patch based on gcc version at merge time is bad, gcc could change just after the emerge.
                                                                                
3) Thoses two patch are bad, basicly they must be split in 3. (atom march fix, add native, add more cpu)
Furthermore, linked to point 2, the patch does not need a specific gcc.         
Due to the use of "call cc-option", not having the right gcc will just lead to the march option ignored. So kernel with thoses patch could perfectly compiled by any gcc.
If gcc conditionnal are needed, they must be done in kconfig.                   
                                                                                
4) It seems that kernel-2 will neither apply anymore thoses 2 patchs due to the "kernel_is ge 4 13", all kernel in tree are now > 4.13
                                                                                
So in the current situation, they are useless, please remove thoses two patchs from all linux-patches
Comment 1 Mike Pagano gentoo-dev 2019-03-06 15:36:20 UTC
Thanks for your thoughts.  We'll consider your thoughts