Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 679284 - net-misc/hath-0.4.2: test failures: shelltests failed
Summary: net-misc/hath-0.4.2: test failures: shelltests failed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael Orlitzky
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks: 678724
  Show dependency tree
 
Reported: 2019-03-02 22:51 UTC by Thomas Deutschmann (RETIRED)
Modified: 2019-03-05 20:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,20.97 KB, text/plain)
2019-03-02 22:51 UTC, Thomas Deutschmann (RETIRED)
Details
hath-x86-overflow.patch (hath-x86-overflow.patch,1.99 KB, patch)
2019-03-03 02:09 UTC, Michael Orlitzky
Details | Diff
build.log with patch1 (build.log,12.96 KB, text/plain)
2019-03-03 02:21 UTC, Thomas Deutschmann (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Deutschmann (RETIRED) gentoo-dev 2019-03-02 22:51:58 UTC
Created attachment 567518 [details]
build.log

:test/shell/manpage-listed.test: [Failed]

Expected stdout:
192.168.0.240
192.168.0.241
192.168.0.242
192.168.0.243
192.168.0.244
192.168.0.245
192.168.0.246
192.168.0.247

Got stdout:
65.168.0.240
65.168.0.241
65.168.0.242
65.168.0.243
65.168.0.244
65.168.0.245
65.168.0.246
65.168.0.247

         Test Cases   Total
 Passed  13           13
 Failed  1            1
 Total   14           14
Test suite shelltests: FAIL




Portage 2.3.51 (python 3.6.5-final-0, default/linux/x86/17.0, gcc-8.2.0, glibc-2.27-r6, 4.19.23-gentoo i686)
=================================================================
System uname: Linux-4.19.23-gentoo-i686-Intel-R-_Core-TM-_i7-3770K_CPU_@_3.50GHz-with-gentoo-2.6
KiB Mem:     3106596 total,   2401916 free
KiB Swap:     488276 total,    483156 free
Timestamp of repository gentoo: Sat, 02 Mar 2019 18:24:14 +0000
Head commit of repository gentoo: a38a42f0ba71f58dbcce1017fb2093b1a54ae657

sh bash 4.4_p23-r1
ld GNU ld (Gentoo 2.30 p5) 2.30.0
app-shells/bash:          4.4_p23-r1::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.26.2::gentoo
dev-lang/python:          2.7.15::gentoo, 3.6.5::gentoo
dev-util/cmake:           3.9.6::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/openrc:          0.38.3-r1::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.16.1-r1::gentoo
sys-devel/binutils:       2.30-r4::gentoo
sys-devel/gcc:            8.2.0-r6::gentoo
sys-devel/gcc-config:     2.0::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 4.14-r1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.27-r6::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000

ABI="x86"
ABI_X86="32"
ACCEPT_KEYWORDS="x86"
ACCEPT_LICENSE="* -@EULA"
ACCEPT_PROPERTIES="*"
ACCEPT_RESTRICT="*"
ANT_HOME="/usr/share/ant"
ARCH="x86"
BROOT=""
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=pentium4m -mtune=pentium4m -Wno-error=jump-misses-init -Wno-error=sign-compare"
CHOST="i686-pc-linux-gnu"
CHOST_x86="i686-pc-linux-gnu"
COLLISION_IGNORE="/lib/modules/*"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CPU_FLAGS_X86="mmx mmxext sse sse2"
CXXFLAGS="-O2 -pipe -march=pentium4m -mtune=pentium4m -Wno-error=jump-misses-init -Wno-error=sign-compare"
DEFAULT_ABI="x86"
EDITOR="/usr/bin/mcedit"
ELIBC="glibc"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
EPREFIX=""
EROOT="/"
ESYSROOT="/"
FCFLAGS="-O2 -march=i686 -pipe"
FEATURES="assume-digests binpkg-logs cgroup config-protect-if-modified distlocks downgrade-backup ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -march=i686 -pipe"
GCC_SPECS=""
GRUB_PLATFORMS="efi-32 pc"
GSETTINGS_BACKEND="dconf"
HOME="/root"
INFOPATH="/usr/share/gcc-data/i686-pc-linux-gnu/8.2.0/info:/usr/share/binutils-data/i686-pc-linux-gnu/2.30/info:/usr/share/info"
INPUT_DEVICES="libinput keyboard mouse"
IUSE_IMPLICIT="abi_x86_32 prefix prefix-chain prefix-guest"
JAVAC="/etc/java-config-2/current-system-vm/bin/javac"
JAVA_HOME="/etc/java-config-2/current-system-vm"
JDK_HOME="/etc/java-config-2/current-system-vm"
KERNEL="linux"
L10N="en en-US de de-DE"
LANG="en_US.UTF-8"
LC_ALL="en_US.UTF-8"
LC_MESSAGES="C"
LC_PAPER="de_DE.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LIBDIR_x86="lib"
LINGUAS="en de"
LOGNAME="root"
MAIL="/var/mail/root"
MAKEOPTS="--jobs 5 --load-average 7.95"
MULTILIB_ABIS="x86"
NETBEANS_MODULES="apisupport cnd groovy gsf harness ide identity j2ee java mobility nb php profiler soa visualweb webcommon websvccommon xml"
NOCOLOR="true"
OFFICE_IMPLEMENTATION="libreoffice"
OPENCL_PROFILE="ocl-icd"
OPENGL_PROFILE="xorg-x11"
PAGER="/usr/bin/less"
PATH="/usr/lib/llvm/6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin"
PHP_TARGETS="php5-6 php7-1 php7-2 php7-3"
POSTGRES_TARGETS="postgres9_5 postgres10"
PWD="/root"
PYTHONDONTWRITEBYTECODE="1"
PYTHON_SINGLE_TARGET="python3_6"
PYTHON_TARGETS="python2_7 python3_6"
QT_GRAPHICSSYSTEM="raster"
ROOT="/"
ROOTPATH="/usr/lib/llvm/6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin"
RUBY_TARGETS="ruby24"
SHELL="/bin/bash"
SHLVL="2"
SSH_TTY="/dev/pts/0"
SYSROOT="/"
TERM="tmux-256color"
TMUX="/tmp//tmux-0/default,4135,0"
TMUX_PANE="%2"
TWISTED_DISABLE_WRITING_OF_PLUGIN_CACHE="1"
USER="root"
USERLAND="GNU"
VIDEO_CARDS="vmware"
XDG_CONFIG_DIRS="/etc/xdg"
XDG_DATA_DIRS="/usr/local/share:/usr/share"
Comment 1 Michael Orlitzky gentoo-dev 2019-03-02 23:12:32 UTC
Well *that* is an interesting error. Fortunately this is a very simple test. If you can install hath (by disabling the test suite temporarily), then said test is  executing

  echo 192.168.0.240/29 | hath listed

via /bin/sh. Can you run it manually and see what happens?

And what does

  echo 192.168.0.240/29

output? (It should output "192.168.0.240/29").

Thanks for the test & report.
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2019-03-02 23:19:39 UTC
# emerge -a1 hath

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild  N    ~] net-misc/hath-0.4.2::gentoo  USE="-test" 0 KiB

Total: 1 package (1 new), Size of downloads: 0 KiB

Would you like to merge these packages? [Yes/No] y
>>> Verifying ebuild manifests
>>> Emerging (1 of 1) net-misc/hath-0.4.2::gentoo
>>> Installing (1 of 1) net-misc/hath-0.4.2::gentoo
>>> Jobs: 1 of 1 complete                           Load avg: 0.71, 0.20, 0.17
>>> Auto-cleaning packages...

>>> No outdated packages were found on your system.

 * GNU info directory index is up-to-date.
vm-gentoo-x86 ~ # echo 192.168.0.240/29 | hath listed
65.168.0.240
65.168.0.241
65.168.0.242
65.168.0.243
65.168.0.244
65.168.0.245
65.168.0.246
65.168.0.247

vm-gentoo-x86 ~ # ls -al /bin/sh
lrwxrwxrwx 1 root root 4 Jan 15 19:58 /bin/sh -> bash

vm-gentoo-x86 ~ # bash --version
bash --version
GNU bash, version 4.4.23(1)-release (i686-pc-linux-gnu)
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.



...same with /bin/sh -> dash (app-shells/dash-0.5.9.1-r3).
Comment 3 Thomas Deutschmann (RETIRED) gentoo-dev 2019-03-02 23:20:14 UTC
vm-gentoo-x86 /bin # echo 192.168.0.240/29
192.168.0.240/29
Comment 4 Michael Orlitzky gentoo-dev 2019-03-02 23:32:46 UTC
Aha, the build log shows a bunch of other test failures too, most likely due to

  src/IPv4Address.hs:435:23: warning: [-Woverflowed-literals]
    Literal 3232235520 is out of the Int range -2147483648..2147483647

I guess that's why we do this. Thanks again.
Comment 5 Michael Orlitzky gentoo-dev 2019-03-03 02:09:13 UTC
Created attachment 567522 [details, diff]
hath-x86-overflow.patch

If you're feeling adventurous, can you try this patch?

I'm stabbing in the dark since I don't have an x86 system available any longer. I found the place where using an int32 (in place of int64) creates this bug on my system, and I've switched the code to use a uint32 there instead of whatever "int" is.

I'll need a new release to fix the bug, in any case.
Comment 6 Thomas Deutschmann (RETIRED) gentoo-dev 2019-03-03 02:21:57 UTC
Created attachment 567524 [details]
build.log with patch1

Patch doesn't help, see new build.log.
Comment 7 Michael Orlitzky gentoo-dev 2019-03-03 02:32:28 UTC
That one's actually a lot better. Now it's down to one property test failing, instead of basically everything failing. I'll sleep on it and try again tomorrow. Thanks!
Comment 8 Michael Orlitzky gentoo-dev 2019-03-04 04:25:24 UTC
(In reply to Michael Orlitzky from comment #7)
> Now it's down to one property test failing

This turned out to be a bug in the test, not in the code. Give v0.5.0 (now in the tree) a try when you get a chance.
Comment 9 Thomas Deutschmann (RETIRED) gentoo-dev 2019-03-05 15:13:49 UTC
hath-0.5.0 looks good:

         Test Cases   Total
 Passed  14           14
 Failed  0            0
 Total   14           14
Test suite shelltests: PASS
Test suite logged to: dist/test/hath-0.5.0-shelltests.log
2 of 2 test suites (2 of 2 test cases) passed.
Comment 10 Michael Orlitzky gentoo-dev 2019-03-05 20:04:14 UTC
Thanks for testing. I'll wait about a week for good measure, and then ask for stabilization of v0.5.0 instead, since that's a pretty ugly bug on x86.