Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 679028 - signed-off-by check rejecting commit with valid signed-off-by footer
Summary: signed-off-by check rejecting commit with valid signed-off-by footer
Status: CONFIRMED
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: Git (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Infrastructure
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-28 06:47 UTC by Robin Johnson
Modified: 2022-06-16 03:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2019-02-28 06:47:36 UTC
This commit is being rejected:
https://github.com/gentoo/genkernel/pull/4/commits/b9b6c2d98aa19edcfda95a65c417719e714a67be

remote: FATAL: VREF/proj-gentoo-06-copyright: helper program exit status 256
remote: b9b6c2d98aa19edcfda95a65c417719e714a67be: missing Signed-off-by on commit
remote: 
remote: Please make sure to read the copyright policy before adding Signed-off-by!
remote:   https://www.gentoo.org/glep/glep-0076.html
remote: error: hook declined to update refs/heads/master
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-02-28 06:57:56 UTC
Weird.  I've just tried it locally and got a different (correct) result:

9a9f28595a6361d96ac2b1d77e03b0cfaeee2b03: no Signed-off-by line matching committer's e-mail address found!
  expected: mgorny@gentoo.org
  last found: G.Jaekel@DNB.DE

Please make sure to read the copyright policy before adding Signed-off-by!
  https://www.gentoo.org/glep/glep-0076.html
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-02-28 06:58:42 UTC
Could you give me the exact local commit you're trying to push?
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2019-02-28 17:47:55 UTC
(In reply to Michał Górny from comment #2)
> Could you give me the exact local commit you're trying to push?

Look at my original genkernel repo:
Has this merge commit:
https://github.com/robbat2/genkernel/commit/7c6359be41ce8cdbf27f55c4b3c49ec4e9711ca4
with the feature branch of that merge being the exact commit I linked earlier:
https://github.com/robbat2/genkernel/commit/b9b6c2d98aa19edcfda95a65c417719e714a67be
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-02-28 18:30:40 UTC
Looking at the commit under the git-cat-file-scope, I see that the commit message contains CRLF line endings, and lack terminating LF on the last line.  The former probably doesn't cause any harm but the latter seems to prevent bash from processing the last line ('read -r' does not read it).

E.g.:
$printf 'foo' | read -r var ; echo $var

(gives nothing)
Comment 5 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-06-16 03:03:23 UTC
So a genuine issue with the commit, then?