Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 67893 - baselayout-1.9.4-r3 ebegin() misuses NO_COLOR?
Summary: baselayout-1.9.4-r3 ebegin() misuses NO_COLOR?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] baselayout (show other bugs)
Hardware: All Linux
: High minor
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-17 09:03 UTC by Elan Ruusamäe
Modified: 2004-10-18 10:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elan Ruusamäe 2004-10-17 09:03:37 UTC
it's just plain strange. i think irrelevant code is left in.
if it's not true, then there should be comment why the code is as it is there.

# void ebegin(char* message)
#
#    show a message indicating the start of a process
#
ebegin() {
    if [ "${RC_QUIET_STDOUT}" != "yes" ]
    then
        if [ "${RC_NOCOLOR}" = "yes" ]
        then
            echo -ne " ${GOOD}*${NORMAL} ${*}..."
        else
            echo -e " ${GOOD}*${NORMAL} ${*}..."
        fi
    fi

    return 0
}


Reproducible: Always
Steps to Reproduce:
with --nocolor i see three 'ok' messages, so i still consider it a bug :)

# /etc/init.d/samba --nocolor reload
 * samba -> reload: smbd ...  [ ok ]
 * samba -> reload: nmbd ...  [ ok ]
  [ ok ]
# /etc/init.d/samba reload
 * samba -> reload: smbd ...        [ ok ]
 * samba -> reload: nmbd ...        [ ok ]
#
Comment 1 SpanKY gentoo-dev 2004-10-18 07:14:23 UTC
this is fixed in cvs already
Comment 2 Elan Ruusamäe 2004-10-18 10:16:10 UTC
is the cvs available publically?
is there some cvsweb interface?
:)
Comment 3 SpanKY gentoo-dev 2004-10-18 10:21:48 UTC
there's a link to viewcvs from the gentoo.org page

we dont have anon cvs available atm, we took it down because of the high loads it was causing ... developers couldnt use cvs like that :(