Bug 678542 – =app-laptop/tp_smapi-0.43 stable request

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Sebastian Hamann 2019-02-22 06:12:53 UTC]

Current stable =app-laptop/tp_smapi-0.42-r1 does not compile against current stable kernel 4.19 (or kernel from 4.15, cf. #646096).
=app-laptop/tp_smapi-0.43 works well, so I believe it should be stabilized.

Reproducible: Always

Steps to Reproduce:
1. USE=symlink emerge =gentoo-sources-4.19.23
2. emerge tp_smapi

Actual Results:  
Compiling breaks with:

/var/tmp/portage/app-laptop/tp_smapi-0.42-r1/work/tp_smapi-0.42/hdaps.c: In function ‘hdaps_init’:
/var/tmp/portage/app-laptop/tp_smapi-0.42-r1/work/tp_smapi-0.42/hdaps.c:781:2: error: implicit declaration of function ‘init_timer’; did you mean ‘init_timers’? [-Werror=implicit-function-declaration]
  init_timer(&hdaps_timer);
  ^~~~~~~~~~
  init_timers
/var/tmp/portage/app-laptop/tp_smapi-0.42-r1/work/tp_smapi-0.42/hdaps.c:782:23: error: assignment from incompatible pointer type [-Werror=incompatible-pointer-types]
  hdaps_timer.function = hdaps_mousedev_poll;
                       ^
cc1: some warnings being treated as errors


Expected Results:  
app-laptop/tp_smapi compiles and installs correctly

[Comment 1 Michael Orlitzky 2019-02-22 12:52:33 UTC]

Thanks for the report. Arches, go ahead. This needs special hardware, so a compile test is fine. I've tested on amd64, but on x86 we'll just have to have faith these days.

[Comment 2 Mikle Kolyada (RETIRED) 2019-03-02 15:24:08 UTC]

amd64 stable

[Comment 3 Thomas Deutschmann (RETIRED) 2019-03-02 20:51:31 UTC]

x86 stable, closing