Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 678340 - sys-apps/portage: ACCEPT_LICENSE settings in profiles are not incremental
Summary: sys-apps/portage: ACCEPT_LICENSE settings in profiles are not incremental
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Configuration (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-18 21:44 UTC by Zac Medico
Modified: 2019-04-16 11:24 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zac Medico gentoo-dev 2019-02-18 21:44:22 UTC
ACCEPT_LICENSE has support for things like "* -@EULA" which do not follow the usual incremental variable behavior. Since it has a different implementation, ACCEPT_LICENSE settings in profiles are not incremental with respect to each other, but ACCEPT_LICENSE settings in make.conf are incremental with respect to the profile setting.
Comment 1 Zac Medico gentoo-dev 2019-02-18 21:49:02 UTC
Given the deviance in behavior from usual incremental variables, I recommend that profiles do something like this if they want incremental like behavior:

ACCEPT_LICENSE="${ACCEPT_LICENSE} foo"
Comment 2 Joakim Tjernlund 2019-02-19 14:51:15 UTC
Thanks, this saved my day :)
Comment 3 Ulrich Müller gentoo-dev 2019-04-16 11:24:43 UTC
PMS defines incremental variables in section 5.3.1:
https://projects.gentoo.org/pms/7/pms.html#x1-560005.3.1

"Other variables, except where they affect only package-manager-specific functionality (such as Portage’s FEATURES variable), must not be treated incrementally—later definitions shall completely override those in parent profiles."

So from a PMS point of view either behaviour would be fine.