Created attachment 560906 [details, diff] Patch to fix compilation The patch changes #include <lv2.h> to #include <lv2/lv2.h> in libs/ardour/ardour/uri_map.h.
It's useful to know which bug you think you're patching, so please don't send in a patch that fixes "the error", but show us the actual compilation error.
Hmm, I don't know what is unclear in my original subject line: "media-sound/ardour-5.12 with media-libs/lv2: lv2.h not found in libs/ardour/ardour/uri_map.h"? Of course I meant to write "media-libs/lv2-1.14.1", but otherwise it's simply that compilation fails in the line "#include <lv2.h>" with the error "lv2.h not found". How is that an "undisclosed error"? Obviously the include file lv2.h was present in /usr/include in a previous version of lv2 but now it's in /usr/include/lv2.
(In reply to Bernd Feige from comment #2) > Hmm, I don't know what is unclear in my original subject line: > "media-sound/ardour-5.12 with media-libs/lv2: lv2.h not found in > libs/ardour/ardour/uri_map.h"? > > Of course I meant to write "media-libs/lv2-1.14.1", but otherwise it's > simply that compilation fails in the line "#include <lv2.h>" with the error > "lv2.h not found". How is that an "undisclosed error"? > > Obviously the include file lv2.h was present in /usr/include in a previous > version of lv2 but now it's in /usr/include/lv2. Same here, patch is OK and necessary.
unpached package complied without error on my system
Thanks for reporting! But lv2-1.14.1 is not in tree yet and the patch would break a compile against in-tree lv2 afaics. There seems to be a fix coming... https://github.com/drobilla/lv2/commit/96a6283a5fe023c59113242631f337da5f0eb278
(In reply to Bernd Feige from comment #2) > Hmm, I don't know what is unclear in my original subject line Looking for the exact error as output of the compiler might be what people look for in searching existing bug reports, and the bugzilla duplication tracker would also find a similarly described bug report that way, so including the complete error message in the Summary helps people find bug reports in several ways.
(In reply to Jeroen Roovers from comment #6) > (In reply to Bernd Feige from comment #2) > > Hmm, I don't know what is unclear in my original subject line > > Looking for the exact error as output of the compiler might be what people > look for in searching existing bug reports, and the bugzilla duplication > tracker would also find a similarly described bug report that way, so > including the complete error message in the Summary helps people find bug > reports in several ways. 'Undisclosed error' doesn't help a lot for discoverability I'd assume. Set the summary now to include the actual compiler output.
(In reply to Andreas Schürch from comment #5) > Thanks for reporting! > > But lv2-1.14.1 is not in tree yet and the patch would break a compile > against in-tree lv2 afaics. > > There seems to be a fix coming... > https://github.com/drobilla/lv2/commit/ > 96a6283a5fe023c59113242631f337da5f0eb278 Exactly. I Just confirmed that current lv2 1.16.0 is backwards compatible, ie ardour-5.12 doesn't need the patch any more. See also https://bugs.gentoo.org/696394
we won't have 1.14.1 as we now have 1.16.0 in the tree which fixes this issue (that was never part of the tree).
