Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 674706 - net-misc/curl should configure with --with-default-ssl-backend=NAME
Summary: net-misc/curl should configure with --with-default-ssl-backend=NAME
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL: https://github.com/curl/curl/commit/c...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-06 17:26 UTC by Jeroen Roovers (RETIRED)
Modified: 2020-08-06 14:13 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2019-01-06 17:26:43 UTC
.../work/curl-7.63.0 $ ./configure --help
...
  --with-default-ssl-backend=NAME
                          Use NAME as default SSL backend
  --without-default-ssl-backend
                          Use implicit default SSL backend


If this is correct, then CURL_WITH_MULTI_SSL can kick in and support several backends at once and REQUIRED_USE can be relaxed. Additionally, this causes the build to fail like it should in src_configure() when 

    AC_MSG_ERROR([Default SSL backend $DEFAULT_SSL_BACKEND not enabled!])

is issued. Now, instead, if the chosen SSL backend is faulty, you get warnings instead:

  AC_MSG_WARN([SSL disabled, you will not be able to use HTTPS, FTPS, NTLM and more.])
  AC_MSG_WARN([Use --with-ssl, --with-gnutls, --with-polarssl, --with-cyassl, --with-nss, --with-winssl, --with-darwinssl, or --with-mesalink to address this.])

and it "succeeds" in building and installing when it should not.
Comment 1 Anthony Basile gentoo-dev 2020-07-23 13:07:37 UTC
A contributor has proposed a solution at [1] but hasn't finished the work yet.  I believe I can fix the incorrect build issue, however, by just adding --with-default-ssl-backend=NAME to each of the possibilities, eg


if use curl_ssl_gnutls; then
    einfo "SSL provided by gnutls"
    myconf+=( --with-gnutls --with-nettle --with-default-ssl-backend=gnutls  )


Ref.
[1] https://github.com/gentoo/gentoo/pull/16592
Comment 2 Anthony Basile gentoo-dev 2020-08-06 14:13:27 UTC
(In reply to Anthony Basile from comment #1)
> A contributor has proposed a solution at [1] but hasn't finished the work
> yet.  I believe I can fix the incorrect build issue, however, by just adding
> --with-default-ssl-backend=NAME to each of the possibilities, eg
> 
> 
> if use curl_ssl_gnutls; then
>     einfo "SSL provided by gnutls"
>     myconf+=( --with-gnutls --with-nettle --with-default-ssl-backend=gnutls 
> )
> 
> 
> Ref.
> [1] https://github.com/gentoo/gentoo/pull/16592

Okay, I've committed the above pr to the tree.  I should address this problem.  Let's start opening up new bugs for any issues with the new ebuild.