Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 674502 - www-client/firefox - SafeBrowsing does not work
Summary: www-client/firefox - SafeBrowsing does not work
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-04 13:02 UTC by vm666
Modified: 2019-01-29 22:07 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description vm666 2019-01-04 13:02:32 UTC 
SafeBrowsing works with the binary package www-client/firefox-bin, but it does not work if the browser is recompiled from the source package www-client/firefox

SafeBrowsing can be tested on https://testsafebrowsing.appspot.com/
At least, the option should be greyed out to inform the user that the feature is not available.

See also: https://forums.gentoo.org/viewtopic-p-8273008.html
Comment 1 vm666 2019-01-04 13:06:14 UTC 
Same problem with chrome and whromium. See bug 674504
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2019-01-05 14:51:36 UTC 
Thank you for the report, I confirm that SafeBrowsing isn't working in our own firefox build.
Comment 3 Thomas Deutschmann (RETIRED) gentoo-dev 2019-01-05 17:31:43 UTC 
We have reached Gentoo's API limit. We have to contact Google to increase our limit.
Comment 4 vm666 2019-01-05 17:39:34 UTC 
(In reply to Thomas Deutschmann from comment #3)
> We have reached Gentoo's API limit. We have to contact Google to increase
> our limit.

Is this the same problem with Chromium? (bug 674504)
Comment 5 Thomas Deutschmann (RETIRED) gentoo-dev 2019-01-05 18:45:04 UTC 
Yes it is.
Comment 6 Alec Warner (RETIRED) archtester gentoo-dev Security 2019-01-11 23:36:08 UTC 
Action Items:

P1:
Escalate to Safebrowsing team to get quota bumped for our existing API key.
Escalate to Geo API team to get quota bumped for our Geo API.

P2:

The current API key is associated with a random google cloud account. We recently created a Gentoo owned GCP project and we should move to a key that is key'd to that account, as opposed to the account of an arbitrary developer.

-A
Comment 7 Alec Warner (RETIRED) archtester gentoo-dev Security 2019-01-15 14:39:22 UTC 
(In reply to Alec Warner from comment #6)
> Action Items:
> 
> P1:
> Escalate to Safebrowsing team to get quota bumped for our existing API key.
> Escalate to Geo API team to get quota bumped for our Geo API.
> 
> P2:
> 
> The current API key is associated with a random google cloud account. We
> recently created a Gentoo owned GCP project and we should move to a key that
> is key'd to that account, as opposed to the account of an arbitrary
> developer.
> 
> -A

I have a conference with a contact at Google on Thursday to discuss next steps to resolution.

-A
Comment 8 Thomas Deutschmann (RETIRED) gentoo-dev 2019-01-29 16:43:35 UTC 
@vm666: Can you confirm that SafeBrowsing is working for you again?
Comment 9 vm666 2019-01-29 17:16:24 UTC 
With www-client/firefox-64.0.2, SafeBrowsing works partially:
https://testsafebrowsing.appspot.com/s/phishing.html is OK
But https://testsafebrowsing.appspot.com/s/image_small.html is not reported, while it is reported by Google Chrome.

Should I compile www-client/firefox-65.0?
Comment 10 Thomas Deutschmann (RETIRED) gentoo-dev 2019-01-29 22:07:40 UTC 
No, this is fine, https://testsafebrowsing.appspot.com/s/image_small.html is not supposed to trigger SafeBrowsing in Firefox.

So initial issue is resolved, quotas were increased. Thanks for reporting.