673160 – dev-vcs/git-9999* should not apply patches

Bug 673160 - dev-vcs/git-9999* should not apply patches

Summary: dev-vcs/git-9999* should not apply patches

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Robin Johnson

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2018-12-14 23:34 UTC by William Hubbs
Modified:	2018-12-17 18:59 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description William Hubbs gentoo-dev

2018-12-14 23:34:46 UTC

I have been asked to work on a patch for git upstream.
My patch applies as it should to the git master branch if I clone the
upstream repository directly. However, I have been unable to drop my
patch in /etc/portage/patches/dev-vcs/git and get it to apply to 9999 or
9999-r1.

After looking around, i found that the *9999* ebuilds apply patches to
the source themselves.

They probably shouldn't do this so we can apply user patches to them to
test before we send them upstream.

Comment 1 Robin Johnson archtester

2018-12-15 06:34:31 UTC

I disagree that it should not apply patches.

The patches fix building, and have been turned down by upstream previously.

Please share your draft patch so we can look at why doesn't apply.

Comment 2 William Hubbs gentoo-dev

2018-12-17 18:59:41 UTC

I attempted this again and I was able to successfully apply the patch.