Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 673102 - net-misc/openssh: consider adding systemd notify support
Summary: net-misc/openssh: consider adding systemd notify support
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-13 23:46 UTC by Andrius Štikonas
Modified: 2019-01-01 14:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrius Štikonas 2018-12-13 23:46:04 UTC
Many of the big distros (Debian + derivatives, Fedora, etc...) patch use Type=notify for openssh systemd unit file instead of Type=simple.

Unfortunately, this requires a small patch for OpenSSH (see systemd_readiness patch in https://sources.debian.org/patches/openssh/1:7.4p1-10+deb9u4/)

This makes detecting successful OpenSSH startup more reliable.

Do we want this in Gentoo?

I stumbled upon this while investigating:
https://github.com/gsauthof/dracut-sshd/issues/2#issuecomment-447111404

Reproducible: Always
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-12-13 23:52:03 UTC
Generally, I'm not in favor of adding patches that do not come from upstream...
Comment 2 Andrius Štikonas 2018-12-14 00:12:53 UTC
Well, if consensus is not to add that patch, I'm fine.

I was just trying to figure out sshd timeouts in my initramfs. But I can workaround them locally.
Comment 3 Mike Gilbert gentoo-dev 2018-12-14 06:27:19 UTC
I don't see a very good reason to do this.

Detecting startup errors is mainly useful when other services order themselves after the service being started. I'm not aware of any services that order themselves after sshd.service.

If I'm missing some important use case here, please let me know and we can find a solution.
Comment 4 Andrius Štikonas 2018-12-18 18:12:50 UTC
Well, dracut-sshd project added a note for Gentoo:

https://github.com/gsauthof/dracut-sshd/commit/249c8e87df44c7dde2ef607cc66f69f484f697fb

Shall we close this then?