Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 67242 - init script for cpudyn checks for unnecessary governors
Summary: init script for cpudyn checks for unnecessary governors
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High minor (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-12 09:25 UTC by Chip Marshall
Modified: 2004-10-12 11:01 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Suggested patch (cpudyn.init.patch,673 bytes, patch)
2004-10-12 09:26 UTC, Chip Marshall
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chip Marshall 2004-10-12 09:25:21 UTC
The init.d script included with the 0.99 and above ebuild for sys-apps/cpudyn check to make sure the proper cpufreq governors are present for cpudyn to function. The script checks for the userspace, performance, and powersave governors, however cpudyn does no use the userspace governor. Hence, the script fails unnesessarily if the userspace governor was not compiled into the kernel or loaded as a module.

Note that it only loads the performance and powersave modules.

Reproducible: Always
Steps to Reproduce:
1. Configure/compile/use a kernel with cpufreq enabled with only performance and powersave governors
2. emerge cpudyn
3. /etc/init.d/cpudyn start

Actual Results:  
 * Starting cpudynd...
 * 2.5/2.6 CPUfreq support needs userspace, performance and powersave governors
 * Missing userspace                                                      [ !! ]

Expected Results:  
 * Starting cpudynd...                                                    [ ok ]

Portage 2.0.50-r11 (default-x86-1.4, gcc-3.3.4, glibc-2.3.3.20040420-r2, 2.6.8.1)
=================================================================
System uname: 2.6.8.1 i686 Intel(R) Pentium(R) III Mobile CPU      1133MHz
Gentoo Base System version 1.4.16
distcc 2.16 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.3 [enabled]
Autoconf: sys-devel/autoconf-2.59-r5
Automake: sys-devel/automake-1.8.5-r1
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-mcpu=pentium3 -O3 -pipe -fforce-addr -fomit-frame-pointer
-funroll-loops -frerun-cse-after-loop -frerun-loop-opt -falign-functions=4"
CHOST="i686-pc-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3/share/config /usr/share/config /usr/share/texmf/dvipdfm/config/
/usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/
/usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-mcpu=pentium3 -O3 -pipe -fforce-addr -fomit-frame-pointer
-funroll-loops -frerun-cse-after-loop -frerun-loop-opt -falign-functions=4"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache sandbox userpriv usersandbox"
GENTOO_MIRRORS="http://gentoo.osuosl.org
http://distro.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X aalib acpi aim alsa apache2 avi berkdb bitmap-fonts cdr chroot crypt cups
curl dga divx4linux dvd dvdread encode ethereal f77 flac foomaticdb gd gdbm gpm
gps gtk gtk2 hostap-nopci hostap-noplx imap imlib jabber java jikes joystick
jpeg libcaca libg++ libwww mad mikmod mmx mng motif mpeg mysql ncurses nls
offensive oggvorbis opengl oscar pam pcmcia pda pdflib perl png pnp python qt
quicktime radeon readline rtc sdl socks5 spell sse ssl tcltk tcpd tetex theora
tiff truetype usb video_cards_radeon wxwindows x86 xml2 xmms xprint xv xvid xvmc
yahoo zlib"
Comment 1 Chip Marshall 2004-10-12 09:26:52 UTC
Created attachment 41628 [details, diff]
Suggested patch

Here's my suggested patch to fix the problem, it's simply a removal of
'userspace' from the argument list for the for loop that checks for the
governors.
Comment 2 SpanKY gentoo-dev 2004-10-12 11:01:46 UTC
removed the check all together