Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 671520 - sys-kernel/gentoo-sources please include patch for I2C_AMD_MP2 driver
Summary: sys-kernel/gentoo-sources please include patch for I2C_AMD_MP2 driver
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL: https://lore.kernel.org/patchwork/pro...
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks:
 
Reported: 2018-11-19 16:08 UTC by Chí-Thanh Christopher Nguyễn
Modified: 2019-07-08 12:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chí-Thanh Christopher Nguyễn gentoo-dev 2018-11-19 16:08:48 UTC 
A number of recent AMD Ryzen laptops use an ARM based I2C controller called "MP2" for which no driver is in mainline yet. This typically controls functions like touchpads or touchscreens.

The most recent version (v10 at the time of writing) was posted to the linux-i2c mailing list can be found at this bug report's URL field.

I tested this driver to apply against and work with gentoo-sources-4.19.2. Please consider adding this driver to gentoo-sources.
Comment 1 Alice Ferrazzi Gentoo Infrastructure gentoo-dev 2018-11-20 14:33:30 UTC 
ok thanks you
Comment 2 Mike Pagano gentoo-dev 2018-11-21 23:58:57 UTC 
Hi, Chí-Thanh,

This driver is still being discussed[1] on the upstream mailing list with the latest version posted a week ago with no response as of this comment writing.

I'd be happier if we added this to genpatches under the 'experimental' use flag.

Is that acceptable to you?

[1] https://lkml.org/lkml/2018/11/14/748
Comment 3 Chí-Thanh Christopher Nguyễn gentoo-dev 2018-11-23 01:26:56 UTC 
I think there is not really a risk here as the driver defaults to N, and even if built, will only initialize on laptops that have an AMD MP2 I2C controller. Those systems will not work properly without the driver anyway.

Note that Ubuntu already ships an older version of this patch, enabled by default for all users.
Comment 4 Chí-Thanh Christopher Nguyễn gentoo-dev 2019-01-02 09:28:46 UTC 
v15 of the driver has been accepted for merging in the upcoming 4.22 merge window.

https://www.spinics.net/lists/linux-i2c/msg38330.html
https://www.spinics.net/lists/linux-i2c/msg38332.html
Comment 5 Chí-Thanh Christopher Nguyễn gentoo-dev 2019-04-08 10:39:15 UTC 
After some delay in mainlining for extra discussion, i2c_amd_mp2 is now merged in i2c-next for kernel 5.2 release.

https://www.spinics.net/lists/linux-i2c/msg39682.html
Comment 6 Mike Pagano gentoo-dev 2019-04-10 18:24:26 UTC 
Chithanh,

Can you find me the patch set here ?

https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/

I looked in i2c/for-next, as indicated, but I can't find the series.

https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/log/?h=i2c/for-next

Am I looking in the wrong repo ?
Comment 8 Chí-Thanh Christopher Nguyễn gentoo-dev 2019-07-08 12:33:59 UTC 
sys-kernel/gentoo-sources-5.2.0 is now in tree with mainline i2c_amd_mp2, no point in adding this to older kernels now
Comment 9 Michael 'veremitz' Everitt 2019-07-08 12:37:10 UTC 
Is there any plan for upstream to backport it? Or are you happy that it WORKSFORME ?! :)