Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 671102 - Git hook rejects committing tag to proj/linux-patches
Summary: Git hook rejects committing tag to proj/linux-patches
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: Git (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Infrastructure
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-13 21:09 UTC by Mike Pagano
Modified: 2018-11-14 13:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Pagano gentoo-dev 2018-11-13 21:09:21 UTC 
Commands:

git -C /home/mike/gentoo/linux-patches tag -s 4.19-3

git push --tags -u origin 4.19

Output:

Enumerating objects: 1, done.
Counting objects: 100% (1/1), done.
Writing objects: 100% (1/1), 808 bytes | 808.00 KiB/s, done.
Total 1 (delta 0), reused 0 (delta 0)
remote: fatal: Invalid revision range 0000000000000000000000000000000000000000..dd2c3f14d48dbb8db0e58c3f4bca46e62d2332b7
remote: FATAL: VREF/proj-gentoo-06-copyright: helper program exit status 256
remote: 4196ed330cd049bfd7781bc2f3e71b646e13a0bd: no GCO sign-off present
remote: error: hook declined to update refs/tags/4.19-3
To git+ssh://git.gentoo.org/proj/linux-patches.git
 ! [remote rejected] 4.19-3 -> 4.19-3 (hook declined)
Branch '4.19' set up to track remote branch '4.19' from 'origin'.
error: failed to push some refs to 'git+ssh://git@git.gentoo.org/proj/linux-patches.git'
Comment 1 Mike Pagano gentoo-dev 2018-11-13 21:11:10 UTC 
I also tried:

Commands:

git -C /home/mike/gentoo/linux-patches tag -s 4.19-3
git push --signed --tags -u origin 4.19

Enumerating objects: 1, done.
Counting objects: 100% (1/1), done.
Writing objects: 100% (1/1), 808 bytes | 808.00 KiB/s, done.
Total 1 (delta 0), reused 0 (delta 0)
remote: fatal: Invalid revision range 0000000000000000000000000000000000000000..dd2c3f14d48dbb8db0e58c3f4bca46e62d2332b7
remote: FATAL: VREF/proj-gentoo-06-copyright: helper program exit status 256
remote: 4196ed330cd049bfd7781bc2f3e71b646e13a0bd: no GCO sign-off present
remote: error: hook declined to update refs/tags/4.19-3
To git+ssh://git.gentoo.org/proj/linux-patches.git
 ! [remote rejected] 4.19-3 -> 4.19-3 (hook declined)
Branch '4.19' set up to track remote branch '4.19' from 'origin'.
error: failed to push some refs to 'git+ssh://git@git.gentoo.org/proj/linux-patches.git'
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-11-13 21:52:26 UTC 
Blame goes to Alice for committing without signoff.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-11-13 21:58:44 UTC 
I'm not sure what to do here.

Technically, I could disable the hook until you stop maintaining old branches that contain commits without signatures and then reenable it when we can reliably assume master..TAG will contain only commits with signed-off-by.

However, if I disable it then I'm pretty sure people will continue adding new commits without signed-off-by, effectively violating the copyright policy and making it impossible to finally enable the hook.

Any suggestions?
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-11-13 22:03:14 UTC 
That said, from my perspective the easiest solution would be to fix the commits on non-master branches (as compared to master) to actually contain sign-off before pushing a new tag.  The hook lists commits needing fixing every time.