Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 671004 - net-wireless/wpa_supplicant-2.6 default prepare prevents git patches being applied
Summary: net-wireless/wpa_supplicant-2.6 default prepare prevents git patches being ap...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Rick Farina (Zero_Chaos)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-12 14:23 UTC by Mike Auty (RETIRED)
Modified: 2018-11-12 14:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to alter the src_prepare phase to work in a more appropriate directory (wpa-supplicant-2.6-r8-prepare-directory.patch,2.57 KB, patch)
2018-11-12 14:23 UTC, Mike Auty (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Auty (RETIRED) gentoo-dev 2018-11-12 14:23:52 UTC
Created attachment 554962 [details, diff]
Patch to alter the src_prepare phase to work in a more appropriate directory

Hiya, at the moment default in the src_prepare phase is applied at the start to the wpa_supplicant ebuild's src_prepare phase.  This brings about two issues:

* The patches being applied by the default happen under ${S} which is ${WORKDIR}/${P}/${PN}, so patches from upstream git require modification (to remove the ${PN} or add "../") before they can be applied.

* Patches applied in the default src_prepare are applied before patches in the ebuild.  This means that the user cannot ever change patches applied by the ebuild other than by constructing a new ebuild.

Both of these decrease the usefulness of the default src_prepare user patches.  Attached is a diff for wpa_supplicant-2.6-r8 that resets the "${S}" value to its default, removes several "../" and moves the default src_prepare until after all other patches have been applied within the ebuild.

Let me know if you see any issues getting this applied...  5:)