The sort_keywords function used by the KEYWORDS.unsorted expects keywords to be sorted by suffix, for example: ~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~m68k ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86 ~amd64-fbsd ~x86-fbsd ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~x64-solaris Since this may not be obvious to people encountering the error, it would be better if it displayed the expected order for copy/paste. Also, an explanation of the suffix sort algorithm in the man page could be helpful. Suggested patch for copy/paste output: > diff --git a/repoman/lib/repoman/modules/scan/keywords/keywords.py b/repoman/lib/repoman/modules/scan/keywords/keywords.py > index 556f352ad..4e1f5f37e 100644 > --- a/repoman/lib/repoman/modules/scan/keywords/keywords.py > +++ b/repoman/lib/repoman/modules/scan/keywords/keywords.py > @@ -151,8 +151,8 @@ class KeywordChecks(ScanBase): > sorted_keywords = sorted(ebuild.keywords, key=sort_keywords) > if sorted_keywords != ebuild.keywords: > self.qatracker.add_error("KEYWORDS.unsorted", > - "%s/%s.ebuild contains unsorted keywords" % > - (xpkg, y_ebuild)) > + "%s/%s.ebuild contains unsorted keywords (expected: \"%s\")" % > + (xpkg, y_ebuild, ' '.join(sorted_keywords))) > > @property > def runInPkgs(self):
repoman support has been removed per bug 835013. Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.
