Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 670168 - media-video/subdl fork / media-video/subdl-1.1.0 version bump
Summary: media-video/subdl fork / media-video/subdl-1.1.0 version bump
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2018-11-02 18:44 UTC by manwe
Modified: 2018-11-04 22:07 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
subdl-1.1.0.ebuild (subdl-1.1.0.ebuild,661 bytes, text/plain)
2018-11-02 18:44 UTC, manwe
Details

Note You need to log in before you can comment on or make changes to this bug.
Description manwe 2018-11-02 18:44:42 UTC
Created attachment 553896 [details]
subdl-1.1.0.ebuild

Old version (1.0.3) stopped working for me, fortunately there's new one - 1.1.0. Ebuild in attachment. I had to create my own fork of original repositiory for download, because author doesn't create any tags or branches.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2018-11-04 12:34:31 UTC
Comment on attachment 553896 [details]
subdl-1.1.0.ebuild

--- subdl-1.0.3.ebuild
+++ subdl-1.1.0.ebuild
@@ -2,12 +2,12 @@
 # Distributed under the terms of the GNU General Public License v2

 EAPI=5
-PYTHON_COMPAT=( python2_7 )
+PYTHON_COMPAT=( python{3_4,3_5,3_6} )
 inherit python-single-r1

 DESCRIPTION="A command-line tool for downloading subs from opensubtitles.org"
 HOMEPAGE="https://github.com/akexakex/subdl"
-SRC_URI="https://${PN}.googlecode.com/files/${P}.zip"
+SRC_URI="https://github.com/manwe-pl/${PN}/archive/${PV}.tar.gz -> ${P}.tar.gz"

 LICENSE="GPL-3"
 SLOT="0"
@@ -20,7 +20,7 @@

 REQUIRED_USE=${PYTHON_REQUIRED_USE}

-S=${WORKDIR}
+S="${WORKDIR}/${PN}-${PV}"

 src_prepare() {
        python_fix_shebang ${PN}
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2018-11-04 12:37:36 UTC
(In reply to Jeroen Roovers from comment #1)
> Comment on attachment 553896 [details]
> subdl-1.1.0.ebuild
> 
> --- subdl-1.0.3.ebuild
> +++ subdl-1.1.0.ebuild
> @@ -2,12 +2,12 @@
>  # Distributed under the terms of the GNU General Public License v2
> 
>  EAPI=5
> -PYTHON_COMPAT=( python2_7 )
> +PYTHON_COMPAT=( python{3_4,3_5,3_6} )
>  inherit python-single-r1
> 
>  DESCRIPTION="A command-line tool for downloading subs from
> opensubtitles.org"
>  HOMEPAGE="https://github.com/akexakex/subdl"
> -SRC_URI="https://${PN}.googlecode.com/files/${P}.zip"
> +SRC_URI="https://github.com/manwe-pl/${PN}/archive/${PV}.tar.gz ->

If you plan to support this you should also change the HOMEPAGE to reflect that.

> ${P}.tar.gz"

Should fit on the same line as above for clarity.

> -S=${WORKDIR}
> +S="${WORKDIR}/${PN}-${PV}"

The quotation marks are not needed.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2018-11-04 12:38:49 UTC
(In reply to Jeroen Roovers from comment #2)
> (In reply to Jeroen Roovers from comment #1)
> > -S=${WORKDIR}
> > +S="${WORKDIR}/${PN}-${PV}"
> 
> The quotation marks are not needed.

Also, it's the default, so remove it.
Comment 4 manwe 2018-11-04 22:02:59 UTC
New diff:

--- subdl-1.0.3.ebuild	2017-02-28 20:50:50.000000000 +0100
+++ subdl-1.1.0.ebuild	2018-11-04 22:59:04.295185001 +0100
@@ -1,13 +1,13 @@
 # Copyright 1999-2014 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
 
-EAPI=5
-PYTHON_COMPAT=( python2_7 )
+EAPI=6
+PYTHON_COMPAT=( python{3_4,3_5,3_6} )
 inherit python-single-r1
 
-DESCRIPTION="A command-line tool for downloading subs from opensubtitles.org"
+DESCRIPTION="A command-line tool for downloading subtitles from opensubtitles.org"
 HOMEPAGE="https://github.com/akexakex/subdl"
-SRC_URI="https://${PN}.googlecode.com/files/${P}.zip"
+SRC_URI="https://github.com/manwe-pl/${PN}/archive/${PV}.tar.gz -> ${P}.tar.gz"
 
 LICENSE="GPL-3"
 SLOT="0"
@@ -15,14 +15,11 @@
 IUSE=""
 
 RDEPEND="${PYTHON_DEPS}"
-DEPEND="${RDEPEND}
-	app-arch/unzip"
-
+DEPEND="${RDEPEND}"
 REQUIRED_USE=${PYTHON_REQUIRED_USE}
 
-S=${WORKDIR}
-
-src_prepare() {
+src_install() {
+	default
 	python_fix_shebang ${PN}
 }
 


HOMEPAGE is correct, because it's author's repo. And I will switch to it, as a source, as soon as author will grasp the ideas of tags and branches in git. Currently my repo is 1:1 fork with just the tag added.
Comment 5 manwe 2018-11-04 22:07:02 UTC
Ups, wrong. Once again:

--- subdl-1.0.3.ebuild
+++ subdl-1.1.0.ebuild
@@ -1,13 +1,13 @@
 # Copyright 1999-2014 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
 
-EAPI=5
-PYTHON_COMPAT=( python2_7 )
+EAPI=6
+PYTHON_COMPAT=( python{3_4,3_5,3_6} )
 inherit python-single-r1
 
-DESCRIPTION="A command-line tool for downloading subs from opensubtitles.org"
+DESCRIPTION="A command-line tool for downloading subtitles from opensubtitles.org"
 HOMEPAGE="https://github.com/akexakex/subdl"
-SRC_URI="https://${PN}.googlecode.com/files/${P}.zip"
+SRC_URI="https://github.com/manwe-pl/${PN}/archive/${PV}.tar.gz -> ${P}.tar.gz"
 
 LICENSE="GPL-3"
 SLOT="0"
@@ -15,18 +15,12 @@
 IUSE=""
 
 RDEPEND="${PYTHON_DEPS}"
-DEPEND="${RDEPEND}
-	app-arch/unzip"
-
+DEPEND="${RDEPEND}"
 REQUIRED_USE=${PYTHON_REQUIRED_USE}
 
-S=${WORKDIR}
-
-src_prepare() {
-	python_fix_shebang ${PN}
-}
-
 src_install() {
+	default
+	python_fix_shebang ${PN}
 	dobin ${PN}
 	dodoc README.txt
 }