Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 670114 - repoman: Should catch a trailing "/" in SRC_URI instead to crash
Summary: repoman: Should catch a trailing "/" in SRC_URI instead to crash
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-01 23:02 UTC by Jonas Stein
Modified: 2021-12-28 03:46 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Stein gentoo-dev 2018-11-01 23:02:06 UTC
Changed 
SRC_URI="http://${PN}.twibright.com/download/${P}.tar.bz2
to
SRC_URI="http://${PN}.twibright.com/download/${P}.tar.bz2/

links-2.12-r2.ebuild

and repoman manifest crashes. But it should catch it and terminate with something like
"Error: SRC_URI must end with a filename but not a trailing '/'"

Reproducible: Always

Actual Results:  
...

2018-11-01 23:20:52 ERROR 404: Not Found.

!!! Couldn't download 'links2_2.10-2.debian.tar.xz'. Aborting.
!!! Fetch failed for links2_2.10-2.debian.tar.xz, can't update Manifest
Unable to generate manifest.stein@mib:/usr/local/overlays/jstein-overlay/www-client/links$ vim 
links-2.12-r2.ebuild  links-2.8-r1.ebuild   metadata.xml
links-2.12-r3.ebuild  Manifest              
stein@mib:/usr/local/overlays/jstein-overlay/www-client/links$ vim links-2.
links-2.12-r2.ebuild  links-2.12-r3.ebuild  links-2.8-r1.ebuild
stein@mib:/usr/local/overlays/jstein-overlay/www-client/links$ vim links-2.12-r2.ebuild 
stein@mib:/usr/local/overlays/jstein-overlay/www-client/links$ repoman manifest[ERROR] Exception in callback portdbapi.async_fetch_map.<locals>.aux_get_done(<Future finis...bian.tar.xz']>) at /usr/lib64/python3.5/site-packages/portage/dbapi/porttree.py:789
handle: <Handle portdbapi.async_fetch_map.<locals>.aux_get_done(<Future finis...bian.tar.xz']>) at /usr/lib64/python3.5/site-packages/portage/dbapi/porttree.py:789>
Traceback (most recent call last):
  File "/usr/lib64/python3.5/asyncio/events.py", line 127, in _run
    self._callback(*self._args)
  File "/usr/lib64/python3.5/site-packages/portage/dbapi/porttree.py", line 814, in aux_get_done
    {'EAPI':eapi,'SRC_URI':myuris}, use=useflags))
  File "/usr/lib64/python3.5/site-packages/portage/dbapi/porttree.py", line 1534, in _parse_uri_map
    "name: '%s'") % (cpv, uri))
portage.exception.InvalidDependString: getFetchMap(): 'www-client/links-2.12-r2' SRC_URI has no file name: 'http://links.twibright.com/download/links-2.12.tar.bz2/'
--Return--
> /usr/lib64/python3.5/site-packages/portage/util/_eventloop/asyncio_event_loop.py(76)_internal_caller_exception_handler()->None
-> pdb.set_trace()
Comment 1 Jonas Stein gentoo-dev 2021-12-28 02:57:36 UTC
any news?
Comment 2 Jonas Stein gentoo-dev 2021-12-28 03:46:13 UTC
tested again with"https://gitlab.gnome.org/GNOME/ghex/-/archive/4.alpha.1/ghex-4.alpha.1.tar.gz/"

and get now:

!!! getFetchMap(): 'app-editors/ghex-4.0.0_alpha' SRC_URI has no file name: 'https://gitlab.gnome.org/GNOME/ghex/-/archive/4.alpha.1/ghex-4.alpha.1.tar.gz/'
!!! Unable to generate manifest for '/usr/local/overlays/gentoo/app-editors/ghex'.
  manifest.bad [fatal]          1
   app-editors/ghex/Manifest


It does not crash anymore, so I close it.