Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 66879 - New package: phat
Summary: New package: phat
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Chris White (RETIRED)
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks: 66883
  Show dependency tree
 
Reported: 2004-10-09 08:30 UTC by mikael söderholm
Modified: 2004-10-15 18:55 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
phat 0.2.3 ebuild (phat-0.2.3.ebuild,605 bytes, application/octet-stream)
2004-10-09 08:31 UTC, mikael söderholm
Details

Note You need to log in before you can comment on or make changes to this bug.
Description mikael söderholm 2004-10-09 08:30:37 UTC
ebuild for phat widgets needed by specimen

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 mikael söderholm 2004-10-09 08:31:22 UTC
Created attachment 41425 [details]
phat 0.2.3 ebuild
Comment 2 Chris White (RETIRED) gentoo-dev 2004-10-15 18:29:24 UTC
Checking this out too.
Comment 3 Chris White (RETIRED) gentoo-dev 2004-10-15 18:55:57 UTC
Added to cvs :).

A couple o things:

+# $Header: $ 

Need to remember to add the header.  Otherwise there's no
way that repoman will let us commit that.

-KEYWORDS="x86"
+KEYWORDS="~x86"

Initial ebuilds should be ~arch marked until devs can verify that it runs ok.

-IUSE="debug"
+IUSE="debug doc"

I added an extra doc flag explained later.

-        local myconf;
-       use debug || myconf="${myconf} --disable-debug"
-       econf ${myconf} || die
+       econf \
+       $(use_enable debug) \
+       $(use_enable doc gtk-doc) || die
+

There's an easier way than || logic, which is $(use_enable).  Check the 
`man 5 ebuild` docs for information on it.  I also added a doc flag so users
can decide whether or not to install html docs :).

-        make DESTDIR=${D} install || die
-       dodoc AUTHORS COPYING ChangeLog NEWS README TODO
+       make DESTDIR=${D} install || die
+       dodoc AUTHORS ChangeLog NEWS README TODO

removed some whitespace and removed COPYING from docs installed, as it takes
up space and anything that COPYING shows to be impossible to import to the tree
won't get imported anyways :).

Other than that good job :).