Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 667982 - Add check for UnusedLocalFlags
Summary: Add check for UnusedLocalFlags
Status: RESOLVED INVALID
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-07 17:57 UTC by Thomas Deutschmann (RETIRED)
Modified: 2018-10-07 23:27 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Deutschmann (RETIRED) gentoo-dev 2018-10-07 17:57:51 UTC
CI checks for unused flags in metadata.xml and throws "UnusedLocalFlags" error if there is any unused flag. Example:

https://qa-reports.gentoo.org/output/gentoo-ci/13169a0/output.html#media-sound/snapcast

It would be very nice if repoman and CI could do the same checks to avoid things like that.
Comment 1 Zac Medico gentoo-dev 2018-10-07 20:47:34 UTC
I see that you fixed media-sound/snapcast already here:

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8432cb4555e34a85294b90e27da49bb045667a18

If I reverse your patch, I see this:

> 
> RepoMan scours the neighborhood...
>   metadata.bad [fatal]          1
>    media-sound/snapcast/metadata.xml: unused local USE-description: 'test'
> 
> Note: use --include-dev (-d) to check dependencies for 'dev' profiles
> 
> Please fix these important QA issues first.
> RepoMan sez: "Make your QA payment on time and you'll never see the likes of me."

The metadata.bad check is implemented here:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=b0b3fdd9b572d9341e0456c7e1e241c795929224
https://gitweb.gentoo.org/proj/portage.git/commit/?id=4e1ab70684b925f4b5d4caab9670dca2b0ffd262
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2018-10-07 23:27:28 UTC
Sorry for the noise, this change was made by me using `git commit --amend`, no repoman involved. Of course you are right, repoman would have noticed...