Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 667674 - www-client/torbrowser-60.2.1_p802 missing "||die" many times
Summary: www-client/torbrowser-60.2.1_p802 missing "||die" many times
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Overlays (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: poncho
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-03 18:55 UTC by Jonas Stein
Modified: 2019-02-28 08:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Stein gentoo-dev 2018-10-03 18:55:29 UTC 
www-client/torbrowser-60.2.1_p802
there are many ||die missing in the ebuild
Comment 1 poncho 2018-10-03 19:07:34 UTC 
Can you point me to some line numbers where "|| die" is missing? I honestly cant find where they should be added... 

You can link to line numbers on github:
https://github.com/MeisterP/torbrowser-overlay/blob/master/www-client/torbrowser/torbrowser-60.2.1_p802.ebuild#L1
Comment 2 Jonas Stein gentoo-dev 2018-10-03 19:22:12 UTC 
https://devmanual.gentoo.org/ebuild-writing/eapi/
"utilities die on their own, unless the nonfatal command is used"

But you need ||die for all others like echo, sed...

https://github.com/MeisterP/torbrowser-overlay/blob/master/www-client/torbrowser/torbrowser-60.2.1_p802.ebuild#L191

and many more.
Comment 3 poncho 2018-10-03 19:25:53 UTC 
Well, I'm basically mirroring the firefox ebuild. Apparently including the missing die.

https://gitweb.gentoo.org/repo/gentoo.git/tree/www-client/firefox/firefox-60.2.2.ebuild#n247