Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 667596 - app-admin/xstow: EAPI7 revbump, minor updates
Summary: app-admin/xstow: EAPI7 revbump, minor updates
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: erik falor
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2018-10-02 18:22 UTC by Michael Mair-Keimberger (iamnr3)
Modified: 2018-11-18 23:12 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
xstow.patch (xstow.patch,1.47 KB, patch)
2018-10-02 18:23 UTC, Michael Mair-Keimberger (iamnr3) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Mair-Keimberger (iamnr3) 2018-10-02 18:22:55 UTC 
Hi,

This is a simply EAPI7 revbump which also fixes a simple QA warning about a empty dir.
Please review.
Comment 1 Michael Mair-Keimberger (iamnr3) 2018-10-02 18:23:05 UTC 
Created attachment 549036 [details, diff]
xstow.patch

git diff for app-admin/xstow
Comment 2 Jonas Stein gentoo-dev 2018-10-06 12:16:05 UTC 
The PR looks good to me and is clearly fixing mistakes like a missing default or unneeded inherit eutils. 
It improves the quality of the ebuild.
Please point out what is wrong, or leave it open until someone has time to merge it. Thank you.
Comment 3 Virgil Dupras (RETIRED) gentoo-dev 2018-11-14 16:01:29 UTC 
Erik, you're proxied maintainer for this package. Have you reviewed the patch?
Comment 4 erik falor 2018-11-18 23:12:45 UTC 
(In reply to Virgil Dupras from comment #3)
> Erik, you're proxied maintainer for this package. Have you reviewed the
> patch?

I've reviewed and accept this patch.