Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 666754 - sys-fs/f2fs-tools-1.10.0 does not work with fsck at boot time
Summary: sys-fs/f2fs-tools-1.10.0 does not work with fsck at boot time
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-22 11:27 UTC by Charo del Genio
Modified: 2018-10-10 09:19 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Charo del Genio 2018-09-22 11:27:30 UTC
After updating to sys-fs/f2fs-tools-1.10.0, my f2fs file system does not get checked at boot time. Rather, I receive the message

Error: device not specified

and then fsck proceeds with checking the other devices.


For the record, my fstab is the following

/dev/sdb2 /boot vfat defaults,relatime 0 2
/dev/sdb3 f2fs defaults,relatime 0 1
/dev/sda1 none swap sw 0 0
/dev/vg01/root /root ext4 noatime 0 2
/dev/vg01/home /home ext4 noatime 0 2
/dev/vg01/var /var ext4 noatime 0 2
/dev/vg01/tmp /tmp ext4 noatime 0 2
/dev/vg01/kernel /usr/src ext4 noatime 0 2
/dev/vg01/portage /usr/portage ext4 noatime 0 2
Comment 1 Charo del Genio 2018-09-22 11:28:20 UTC
Output of emerge --info

Portage 2.3.49 (python 3.6.5-final-0, default/linux/amd64/17.0/desktop/plasma, gcc-7.3.0, glibc-2.26-r7, 4.17.19-gentoo x86_64)
=================================================================
System uname: Linux-4.17.19-gentoo-x86_64-Intel-R-_Core-TM-_i7-8550U_CPU_@_1.80GHz-with-gentoo-2.4.1
KiB Mem:     7994448 total,   6193520 free
KiB Swap:   16777212 total,  16777212 free
Timestamp of repository gentoo: Sat, 22 Sep 2018 08:00:01 +0000
Head commit of repository gentoo: 7073891c434fa15c7219d2212e38ee5387b971aa
sh bash 4.4_p12
ld GNU ld (Gentoo 2.30 p2) 2.30.0
app-shells/bash:          4.4_p12::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.24.3-r1::gentoo
dev-lang/python:          2.7.15::gentoo, 3.6.5::gentoo
dev-util/cmake:           3.9.6::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/openrc:          0.34.11::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.15.1-r2::gentoo
sys-devel/binutils:       2.30-r2::gentoo
sys-devel/gcc:            7.3.0-r3::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 4.13::gentoo (virtual/os-headers)
sys-libs/glibc:           2.26-r7::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts: 
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-metamanifest: no

parawlay
    location: /usr/local/portage
    masters: gentoo

science
    location: /var/lib/layman/science
    masters: gentoo
    priority: 50

zyrenth
    location: /var/lib/layman/zyrenth
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA AdobeFlash-11.x Oracle-BCLA-JavaSE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/themes/oxygen-gtk/gtk-2.0"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch preserve-libs protect-owned sandbox sfperms strict strict-keepdir unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.bytemark.co.uk/gentoo/ rsync://mirror.bytemark.co.uk/gentoo/ http://mirrors.evowise.com/gentoo/ http://www.mirrorservice.org/sites/distfiles.gentoo.org/ ftp://ftp.mirrorservice.org/sites/distfiles.gentoo.org/ rsync://rsync.mirrorservice.org/distfiles.gentoo.org/"
LANG="en_GB.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en en_GB en_US"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi activities alsa amd64 berkdb branding bzip2 cairo caps cdda cdr cjk cli consolekit crypt css cups cxx dbus declarative dga dri dts dv dvd dvdr emboss encode exif fam ffmpeg filecaps flac fontconfig fortran gdbm gif gimp glamor gmp gpm gstreamer gtk iconv icu idn imagemagick ipv6 jit jpeg kde kipi kwallet lapack latex lcms ldap libass libnotify libtirpc mad mmap mng modules mp3 mp4 mpeg mtp multilib musicbrainz ncurses nls nptl nsplugin ogg opengl openmp pam pango pch pcre pdf phonon plasma png policykit postscript ppds pulseaudio qml qt5 raw readline samba sdl seccomp spell ssl startup-notification svg taglib tcmalloc tcpd threads tiff truetype udev udisks unicode upower usb vdpau vorbis widgets wxwidgets x264 xattr xcb xcomposite xml xmp xv xvid zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon plan sheets stage words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" L10N="en en-GB en-US" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="AMDGPU" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python3_6 python2_7" RUBY_TARGETS="ruby23" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 2 Jonas Stein gentoo-dev 2018-09-27 19:57:25 UTC
Thank you for the report. 
Please recompile the old version does it work again? Please recompile the new version again with -j1 and 
*attach* the logfiles as described on
https://wiki.gentoo.org/wiki/Attach_the_logs_to_the_bug_ticket
The logs must be part of the ticket, but not on external websites.
We need to have all information at hand before ticket assignment, so that the maintainer can look after it in one session with minimal number of callbacks.
Please reopen this ticket (Status:unconfirmed) afterwards.
Comment 3 Charo del Genio 2018-10-05 08:27:57 UTC
So, first of all the old version still works fine.

Then, I don't understand why the request to recompile the new version with -j1, but nonetheless I did it and it still does not work: at boot time, the fsck init script fails with "Error: device not specified".

I don't have the build logs because they get erased immediately after emerging. How do I stop this from happening?

Incidentally, to me this feels like a problem of communication between the fsck init script and the new version of fsck.f2fs, so I don't think that we can detect what the problem is by looking at the compilation logs.
Comment 4 Anthony Basile gentoo-dev 2018-10-06 19:27:35 UTC
(In reply to Charo del Genio from comment #3)
> 
> I don't have the build logs because they get erased immediately after
> emerging. How do I stop this from happening?

yeah this sounds like a runtime problem, not a build time error.

> 
> Incidentally, to me this feels like a problem of communication between the
> fsck init script and the new version of fsck.f2fs, so I don't think that we
> can detect what the problem is by looking at the compilation logs.

do you know how fsck.f2fs is invoked?, ie the full command line of the failing command?
Comment 5 Charo del Genio 2018-10-07 08:27:27 UTC
(In reply to Anthony Basile from comment #4)
> do you know how fsck.f2fs is invoked?, ie the full command line of the
> failing command?

No, but one can read in /etc/init.d/fsck
What seem to be the relevant lines there are

        local fsck_opts= p= check_extra=
        if [ "$RC_UNAME" = Linux ]; then
                local skiptypes
                skiptypes=$(printf 'no%s,' ${net_fs_list} ${extra_net_fs_list})
                [ "${skiptypes}" = "no," ] && skiptypes=""
                fsck_opts="$fsck_opts -C0 -T -t ${skiptypes}noopts=_netdev"
                if [ -z "$fsck_passno" -a -z "$fsck_mnt" ]; then
                        fsck_args=${fsck_args:--A -p}
                        if echo 2>/dev/null >/.test.$$; then
                                rm -f /.test.$$
                                fsck_opts="$fsck_opts -R"
                        fi
                fi
        fi

        trap : INT QUIT
        fsck ${fsck_args:--p} $fsck_opts "$@"

So I guess the problem is somewhere there.
Also, the previous version of fsck.f2fs still works, so one other possibly easy thing to check is how its options changed between versions.
Comment 6 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-10-09 11:57:32 UTC
btw, does newer version fail as well?
Comment 7 Anthony Basile gentoo-dev 2018-10-09 23:24:01 UTC
(In reply to Mikle Kolyada from comment #6)
> btw, does newer version fail as well?

yeah, if it does, then that's the lazy solution :)  else we're going to have to decrypt the above bash.
Comment 8 Charo del Genio 2018-10-10 08:35:39 UTC
(In reply to Mikle Kolyada from comment #6)
> btw, does newer version fail as well?

Just tried with f2fs-tools-1.11.0-r1, and it seems to work fine. I guess whatever bug was introduced in 1.10 got fixed...

I'm marking the bug as resolved (fixed in the new version).
Comment 9 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-10-10 09:19:46 UTC
(In reply to Anthony Basile from comment #7)
> (In reply to Mikle Kolyada from comment #6)
> > btw, does newer version fail as well?
> 
> yeah, if it does, then that's the lazy solution :)  else we're going to have
> to decrypt the above bash.

Thank you for the info, I guess we want to stabilize the newer version then, it has been in the tree for almost a month anyway