Attached is a diff for linesrv-2.1.19.ebuild --> linesrv-2.1.19-r1.ebuild. The linesrv-2.1.19.ebuild doesn't cooperate with the configure script of linesrv as it should. This mainly because of abnormal behaviour of the configure script. An IUSE for crypt has been added and the configure script of linesrv now gets arguments it can deal with correctly. This causes the USE flags to have proper effects as one expects with linesrv-2.1.19-r1.ebuild, which is not the case for linesrv-2.1.19.ebuild (e.g. USE mysql has inverse effect, USE pam doesn't work at all). Furthermore I suggest to stabilize the new ebuild for x86 as soon as possible. The newest currently stabilized linesrv ebuild is for 2.1.6 which is a very old and unstable version of linesrv in my opinion. I'm running linesrv 2.1.17-2.1.19 on x86 for over a year now without any problems. I don't know how it performs on sparc. Stefan Fuchs initiator of LineControl
Created attachment 41273 [details, diff] diff for linesrv-2.1.19.ebuild --> linesrv-2.1.19-r1.ebuild as written in bug description
I'm not sure I see a problem with the following line: econf `use_enable pam pamauth` `use_enable mysql` || die "bad configure" If you have USE="pam mysql" it will run: ./configure --enable-pamauth --enable-mysql but with USE="-pam -mysql" ./configure --disable-pamauth --disable-mysql I'll bump it to -r1 as soon as the sql/pam stuff is sorted out, but I fail to see any bugs with the way it's set up.
The actual bug is in the configure.in of linesrv, not in the ebuild. But I modified the ebuild so it works with linesrv-2.1.19. --enable-pamauth is not accepted by ./confiure. Either you provide --disable-pamauth to disable the usage of pam or no argument to use it. Providing --enable-pamauth will actually disable it too. That's why the econf line in 2.1.19 will cause ./configure to do wrong things. Similar bug with the use of --enable-mysql, mysql support will actually get disabled... only ommiting or using --disable-mysql will work. Enabling is automatic if the header files and libs of libmysqlclient are there. I'll probably fix that in 2.1.20. Until then I suggest to just use the -r1 I provided here which works around that problem. Try it out if you don't beleave me. Do `USE="pam mysql" emerge =net-misc/linesrv-2.1.19`, you can hit ctrl-c when ./configure has finished. With linesrv-2.1.19.ebuild you get ----------------- shutdown support enabled not compiling userauthentication functions --> (crypt & pam: not found or disabled by user). WARNING: you need either crypt or PAM for userauthentication! You have to switch user authentication off in your linesrv.conf to get linesrv running without compiled in userauthentication functions! ----------------- which is wrong. Trying linesrv-2.1.19-r1 I get ----------------- shutdown support enabled using pam for authentication using MySQL backend for supplementary logging ----------------- which is correct. With -r1 and USE="-pam crypt mysql" I get ----------------- shutdown support enabled using crypt for authentication (direct file access) using MySQL backend for supplementary logging ----------------- which is correct too. I tested some other possible combinations too. Instead of using the ebuild to work around a bug in the ./configure script one could also fix the bug in some way, but this requires either -r1 too or 2.1.20. So I decided to work around the bug in 2.1.19-r1.ebuild. Hop I was able to show you the problem, actually not all your fault... ;)
Well... I took a deeper look into the problem. As I'm using AC_ARG_ENABLE, which doesn't distinguish between --enable-feature and --disable-feature, I don't know how to fix our problem right in the ./configure script of linesrv. AC_ARG_ENABLE just tells you whether a --(enable|disable)-feature argument was given or not. ./configure --help lists the available options. As this lists only --disable-pam, --enable-crypt and --disable-mysql the reverse of each of those features is just not supported, resp. has the same effect as the supported one. My solution is to leave this as it is, I don't call this a bug anymore. As long as nobody who knows better is going to change it to support --enable-* as well as --disable-* for all features we have to work around this limitation using the ebuild. Yesterday a user informed me about a mysql related compiling problem. Linesrv was using a depreciated function of libmysqlclient which wasn't supported in certain newer versions anymore. I fixed this in 2.1.20 which is going to be released within about an hour. The tar ball for gentoo is ready. 2.1.19 and 2.1.20 have both been tested in gentoo by myself and are working fine. As long as libmysqlclient doesn't get updated in gentoo we can live fine with 2.1.19-r1. An upgrade of mysql could though require an upgrade of linesrv to 2.1.20. So I suggest a version bump from 2.1.19-r1 to 2.1.20 without even adding 2.1.29-r1 to gentoo cvs. What do you think about this?
2.1.20 is now in portage. Thanks for clearing up the previous problem- I hadn't caught on to that. It would be good to get the --enable-[package] syntax to work instead of relying on the configure script to catch them. This is not a priority, but it would be something to try to fix in the future. If I have time when I get back from the courthouse tonight (need to register to vote), I'll see what I can do about it ;). Thanks for your input and submission!
