Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 66528 - [PATCH] Muine with gst backend crashes on bad escaped files
Summary: [PATCH] Muine with gst backend crashes on bad escaped files
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Peter Johanson (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on: 72770
Blocks:
  Show dependency tree
 
Reported: 2004-10-06 07:48 UTC by foser (RETIRED)
Modified: 2005-01-04 10:29 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to workaround weird filenames (muine-0.6.3-work_around_bad_escaped_files.patch,704 bytes, patch)
2004-10-06 07:48 UTC, foser (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description foser (RETIRED) gentoo-dev 2004-10-06 07:48:03 UTC
Muine crashes on badly escaped files, this seems to be due to some gnome-vfs bug exposed by muine. A quick workaround for muine would be the attached patch as long as gnome-vfs hasn't been investigated. It just checks if vfs can actually get file info & returns if it can't.


A small backtrace that shows the probable vfs problem (note that this bt is already taken from a slightly altered muine codebase).

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 1149189040 (LWP 27864)]
0x42a61e2c in metadata_load (filename=0x1 <Address 0x1 out of bounds>,
    error_message_return=0x447f35ac) at metadata.c:672
672                     gnome_vfs_file_info_unref (info);
(gdb) print info
$1 = (GnomeVFSFileInfo *) 0x8da6ac8
(gdb) print *info
$2 = {name = 0x8daf170 ") - End Of The World.mp3",
  valid_fields = GNOME_VFS_FILE_INFO_FIELDS_NONE,
  type = GNOME_VFS_FILE_TYPE_UNKNOWN, permissions = 0,
  flags = GNOME_VFS_FILE_FLAGS_LOCAL, device = 0, inode = 0, link_count = 0,
  uid = 0, gid = 0, size = 0, block_count = 0, io_block_size = 0, atime = 0,
  mtime = 0, ctime = 0, symlink_name = 0x0, mime_type = 0x0, refcount = 1,
  reserved1 = 0x0, reserved2 = 0x0, reserved3 = 0x0, reserved4 = 0x0,
  reserved5 = 0x0}
(gdb)

The file in this case is  'No Doubt \(Rem Cover\) - End Of The World.mp3'
Comment 1 foser (RETIRED) gentoo-dev 2004-10-06 07:48:46 UTC
Created attachment 41227 [details, diff]
patch to workaround weird filenames
Comment 2 Cletus Lichte 2004-10-28 18:03:58 UTC
I have this very problem with muine.  Otherwise it seems to work well and I'm getting used to using the thing ;)

Will this patch make it into portage soon, or should I start re-naming all my files?  I have a *lot* to re-name.
Comment 3 Cletus Lichte 2004-10-28 18:06:16 UTC
BTW, the files I'm having the problems with have an apostrophe in the name, e.g.:

Yngwie Malmsteen_1984_Rising Force_05_Icarus' Dream Suite Op 4.flac
Comment 4 Peter Johanson (RETIRED) gentoo-dev 2004-12-15 19:54:33 UTC
Please see bug #72770 for an ebuild that should fix the problem. Tested locally, muine survives with an MP3 named like the one foser mentioned. Please report back if it works/doesn't work.
Comment 5 Peter Johanson (RETIRED) gentoo-dev 2005-01-04 10:29:15 UTC
Marking TEST-REQUEST, pending feedback.