664270 – media-gfx/splashutils-1.5.4.4-r8 segmentation fault (patch)

Bug 664270 - media-gfx/splashutils-1.5.4.4-r8 segmentation fault (patch)

Summary: media-gfx/splashutils-1.5.4.4-r8 segmentation fault (patch)

Status:	RESOLVED OBSOLETE

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it

URL:
Whiteboard:	Pending removal: 2018-11-21
Keywords:	PATCH, PMASKED

Depends on:
Blocks:

Reported:	2018-08-22 15:38 UTC by Vasiliy
Modified:	2018-11-28 13:20 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
image buffer size patch (splashutils-1.5.4.4-malloc.patch,449 bytes, patch) 2018-08-22 15:38 UTC, Vasiliy	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Vasiliy 2018-08-22 15:38:41 UTC

Created attachment 544468 [details, diff]
image buffer size patch

fbcondecor_helper segfaults when loading big png.

This is caused by line 104 in image.c:

        *data = malloc(theme->xres * theme->yres * fbd.bytespp);

where xres, yres and bpp are NOT image, but fbdev parameters.

Patch proposal attached. Fixes SEGV, but 8-bit RGB image is funky on 16bpp FB.

Comment 1 Vasiliy 2018-08-23 12:29:55 UTC

RGBA images look ok.

There is code to add alpha, but its under #ifndef TARGET_KERNEL.

Comment 2 Michał Górny archtester

2018-11-28 13:20:05 UTC

Package removed.