Bug 663686 – <sys-apps/diffutils-3.6: fails tests - ../lib/intprops.h:234:4: error: expression in static assertion is not constant

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description eroen 2018-08-15 16:35:16 UTC]

Created attachment 543518 [details]
build.log

aarch64-unknown-linux-gnu-gcc  -I. -I../lib  -DIN_DIFFUTILS_GNULIB_TESTS=1 -I. -I. -I.. -I./.. -I../lib -I./../lib   -Os -g -pipe -mcpu=cortex-a53 -mfix-cortex-a53-843419 -c -o test-intprops.o  test-intprops.c
aarch64-unknown-linux-gnu-gcc  -I. -I../lib  -DIN_DIFFUTILS_GNULIB_TESTS=1 -I. -I. -I.. -I./.. -I../lib -I./../lib   -Os -g -pipe -mcpu=cortex-a53 -mfix-cortex-a53-843419 -c -o test-inttostr.o  test-inttostr.c
In file included from ../lib/intprops.h:24:0,
                 from test-intprops.c:33:
test-intprops.c: In function 'main':
../lib/intprops.h:234:4: error: expression in static assertion is not constant
    __builtin_add_overflow (a, b, (__typeof__ ((a) + (b)) *) 0)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/verify.h:251:31: note: in definition of macro 'verify'
 #define verify(R) _GL_VERIFY (R, "verify (" #R ")")
                               ^
test-intprops.c:162:3: note: in expansion of macro 'VERIFY'
   VERIFY (INT_ADD_OVERFLOW (INT_MAX, 1));
   ^~~~~~
../lib/intprops.h:339:3: note: in expansion of macro '_GL_ADD_OVERFLOW'
   op_result_overflow (a, b,                                     \
   ^~~~~~~~~~~~~~~~~~
../lib/intprops.h:315:3: note: in expansion of macro '_GL_BINARY_OP_OVERFLOW'
   _GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
   ^~~~~~~~~~~~~~~~~~~~~~
test-intprops.c:162:11: note: in expansion of macro 'INT_ADD_OVERFLOW'
   VERIFY (INT_ADD_OVERFLOW (INT_MAX, 1));
           ^~~~~~~~~~~~~~~~
test-intprops.c:146:44: error: expression in static assertion is not constant
     VERIFY (INT_##opname##_OVERFLOW (a, b) == (v))
../lib/verify.h:251:31: note: in definition of macro 'verify'
 #define verify(R) _GL_VERIFY (R, "verify (" #R ")")
                               ^
test-intprops.c:146:5: note: in expansion of macro 'VERIFY'
     VERIFY (INT_##opname##_OVERFLOW (a, b) == (v))
     ^~~~~~
test-intprops.c:148:5: note: in expansion of macro 'CHECK_BINOP'
     CHECK_BINOP(op, opname, a, b, t, v, vres);                            \
     ^~~~~~~~~~~
test-intprops.c:164:3: note: in expansion of macro 'CHECK_SBINOP'
   CHECK_SBINOP (+, ADD, INT_MAX, 1, int, true, INT_MIN);
   ^~~~~~~~~~~~
...
aarch64-unknown-linux-gnu-gcc  -I. -I../lib  -DIN_DIFFUTILS_GNULIB_TESTS=1 -I. -I. -I.. -I./.. -I../lib -I./../lib   -Os -g -pipe -mcpu=cortex-a53 -mfix-cortex-a53-843419 -c -o test-inttypes.o  test-inttypes.c
make[4]: *** [Makefile:3465: test-intprops.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: Leaving directory '/var/tmp/portage/sys-apps/diffutils-3.5/work/diffutils-3.5/gnulib-tests'
make[3]: *** [Makefile:4956: check-am] Error 2
make[3]: Leaving directory '/var/tmp/portage/sys-apps/diffutils-3.5/work/diffutils-3.5/gnulib-tests'
make[2]: *** [Makefile:3483: check-recursive] Error 1
make[2]: Leaving directory '/var/tmp/portage/sys-apps/diffutils-3.5/work/diffutils-3.5/gnulib-tests'
make[1]: *** [Makefile:4959: check] Error 2
make[1]: Leaving directory '/var/tmp/portage/sys-apps/diffutils-3.5/work/diffutils-3.5/gnulib-tests'
make: *** [Makefile:1306: check-recursive] Error 1
 * ERROR: sys-apps/diffutils-3.5::gentoo failed (test phase):
 *   emake failed

[Comment 1 eroen 2018-08-15 16:36:01 UTC]

pine64-a ~ # emerge --info '=sys-apps/diffutils-3.5::gentoo'
Portage 2.3.40 (python 3.6.5-final-0, default/linux/arm64/17.0, gcc-7.3.0, glibc-2.26-r7, 3.10.102-2-pine64-longsleep aarch64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-3.10.102-2-pine64-longsleep-aarch64-with-gentoo-2.4.1
KiB Mem:     2036496 total,   1659064 free
KiB Swap:    2097148 total,   2028076 free
Timestamp of repository gentoo: Tue, 14 Aug 2018 09:00:01 +0000
Head commit of repository gentoo: 5594156a2725ad2551ec02185b2207dc24f70ac7
sh bash 4.4_p12
ld GNU ld (Gentoo 2.30 p2) 2.30.0
app-shells/bash:          4.4_p12::gentoo
dev-lang/perl:            5.24.3-r1::gentoo
dev-lang/python:          2.7.14-r1::gentoo, 3.6.5::gentoo
dev-util/cmake:           3.9.6::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/openrc:          0.34.11::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.69-r4::gentoo
sys-devel/automake:       1.15.1-r2::gentoo
sys-devel/binutils:       2.30-r2::gentoo
sys-devel/gcc:            7.3.0-r3::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1-r3::gentoo
sys-kernel/linux-headers: 4.13::gentoo (virtual/os-headers)
sys-libs/glibc:           2.26-r7::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-max-age: 24
    sync-rsync-extra-opts: 
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-jobs: 1

ACCEPT_KEYWORDS="arm64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="aarch64-unknown-linux-gnu"
CFLAGS="-Os -g -pipe -mcpu=cortex-a53 -mfix-cortex-a53-843419"
CHOST="aarch64-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-Os -g -pipe -mcpu=cortex-a53 -mfix-cortex-a53-843419"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2"
FEATURES="assume-digests binpkg-logs cgroup config-protect-if-modified distlocks ebuild-locks fixlafiles installsources ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch preserve-libs protect-owned sandbox sfperms splitdebug strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_GB.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -mfix-cortex-a53-843419"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl arm64 berkdb bzip2 cli crypt cxx dri fortran gdbm iconv ipv6 libtirpc modules multilib ncurses nls nptl openmp pam pcre readline seccomp ssl tcpd unicode xattr zlib" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon plan sheets stage words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_ARM="edsp neon thumb thumb2 v4 v5 v6 v7 v8 vfp vfp-d32 vfpv3 vfpv4" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby21 ruby23" USERLAND="GNU" VIDEO_CARDS="fbdev dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, MAKEOPTS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

sys-apps/diffutils-3.5::gentoo was built with the following:
USE="nls -static"

pine64-a ~ # emerge -pqv '=sys-apps/diffutils-3.5::gentoo'
[ebuild   R   ] sys-apps/diffutils-3.5  USE="nls -static"

[Comment 2 camper 2018-08-20 22:47:46 UTC]

Created attachment 544220 [details, diff]
diffutils-3.5-fix_macros.patch (fixed)

I observe the same failure on amd64, comparing with diffutils-3.6 it appears that 3.5 tries to use the wrong __builtin_* functions.

Now I see test-failures with test-exclude[1-8] and test-hash.

[Comment 3 camper 2018-08-20 23:33:09 UTC]

Created attachment 544222 [details, diff]
diffutils-3.5-fix_macros.patch v2

With this I observe no more test failures.

[Comment 4 Thomas Deutschmann (RETIRED) 2018-08-21 16:10:26 UTC]

Fixed in diffutils-3.6-r1 so I started stabilization of newer diffutils via bug 664186.

[Comment 5 Sam James 2020-07-04 17:42:18 UTC]

Broken versions no longer in tree.