Bug 663616 – =net-firewall/ipset-6.38 stable request

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Alon Bar-Lev (RETIRED) 2018-08-14 16:12:50 UTC]

Hi robbat2,
I need this to stabilize firehol, even as userland only.
I see some bugs that result from modules as far as I can see, can we please attend these?
Thanks!

[Comment 1 Alon Bar-Lev (RETIRED) 2018-11-11 12:28:25 UTC]

*** Bug 670898 has been marked as a duplicate of this bug. ***

[Comment 2 ernsteiswuerfel 2018-12-27 03:08:08 UTC]

Created attachment 558536 [details]
build.log

Sorry, I completely overlooked this bug! Did some testing now on ppc:

# cat ipset-663616.report 
USE tests started on Do 27. Dez 03:54:26 CET 2018

FEATURES=' test' USE='' succeeded for =net-firewall/ipset-6.34
USE='-modules' succeeded for =net-firewall/ipset-6.34
USE='modules' failed for =net-firewall/ipset-6.34

revdep tests started on Do 27. Dez 03:58:49 CET 2018

FEATURES=' test' USE='ipset' succeeded for net-firewall/firehol

Building with USE='modules' errors out with (see build.log) on my 4.19.12 kernel:
[...]
In file included from /var/tmp/portage/net-firewall/ipset-6.34/work/ipset-6.34/kernel/net/netfilter/ipset/ip_set_bitmap_port.c:202:0:
/var/tmp/portage/net-firewall/ipset-6.34/work/ipset-6.34/kernel/net/netfilter/ipset/ip_set_bitmap_gen.h: In function ‘bitmap_port_gc_init’:
/var/tmp/portage/net-firewall/ipset-6.34/work/ipset-6.34/kernel/net/netfilter/ipset/ip_set_bitmap_gen.h:44:2: error: implicit declaration of function ‘setup_timer’; did you mean ‘sk_stop_timer’? [-Werror=implici
t-function-declaration]
  setup_timer(&map->gc, gc, (unsigned long)set);
  ^~~~~~~~~~~
  sk_stop_timer
[...]

[Comment 3 Robin Johnson 2019-05-25 23:39:37 UTC]

The setup_timer compile with other kernel versions was fixed in 6.35.

[Comment 4 Robin Johnson 2019-05-25 23:42:05 UTC]

Arches, please test & stablize net-firewall/ipset-6.38.

6.38 contains various compile fixes over the older 6.34 version, to work on a wider variety of kernels.

Please test explicitly with only USE=-modules.

If you use USE=modules, it may be very dependent on your kernel version, and the in-kernel ipset is preferred to the out-of-kernel variant.

[Comment 5 Aaron Bauman (RETIRED) 2019-05-26 02:26:45 UTC]

arm64 does not have this stable and I don't see arm64 in the package list.  Please CC us if you still intend for arm64 to make this stable.

[Comment 6 Thomas Deutschmann (RETIRED) 2019-05-26 22:28:46 UTC]

x86 stable

[Comment 7 ernsteiswuerfel 2019-05-29 16:42:54 UTC]

Looking good on ppc.

# cat ipset-663616.report 
USE tests started on Mi 29. Mai 18:39:12 CEST 2019

FEATURES=' test' USE='' succeeded for =net-firewall/ipset-6.38
USE='-modules' succeeded for =net-firewall/ipset-6.38

revdep tests started on Mi 29. Mai 18:40:28 CEST 2019

FEATURES=' test' USE='ipset' succeeded for net-firewall/firehol

[Comment 8 Sergei Trofimovich (RETIRED) 2019-05-30 21:10:50 UTC]

ppc stable

[Comment 9 Sergei Trofimovich (RETIRED) 2019-06-01 11:01:32 UTC]

arm has no stable keywords.

[Comment 10 Agostino Sarubbo 2019-06-04 20:54:46 UTC]

amd64 stable. Closing.