Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 66348 - vixie-cron 4.1 needs ldflags voodoo
Summary: vixie-cron 4.1 needs ldflags voodoo
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Cron Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-04 14:19 UTC by Ciaran McCreesh
Modified: 2004-10-08 08:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ciaran McCreesh 2004-10-04 14:19:35 UTC
vixie-cron 4.1 needs ldflags voodoo as described in solar's post to -core.
Comment 1 Aaron Walker (RETIRED) gentoo-dev 2004-10-05 08:28:06 UTC
Ciaran,

Regarding -s in LDFLAGS, it actually needs to be removed from the gentoo patch, not added.  The original Makefile doesn't set LDFLAGS to anything.
Comment 2 Ciaran McCreesh 2004-10-05 08:34:43 UTC
This should work, no?

	append-ldflags -Wl,-z,now
	sed -i "s:gcc \(-Wall.*\):${CC:-gcc} \1 ${CFLAGS}:" Makefile
	sed -i "s:^\(LDFLAGS[ \t]\+=\):\1 ${LDFLAGS}:" Makefile
Comment 3 Aaron Walker (RETIRED) gentoo-dev 2004-10-05 10:07:13 UTC
I think you misunderstood what I was saying.

What you just posted is what's in the -r2 ebuild.  That works as intended except the -gentoo patch does:

-LDFLAGS                =
+LDFLAGS                = -s

so the -s is kept after the call to sed.
Comment 4 Ciaran McCreesh 2004-10-05 10:59:21 UTC
Bleh, our patch does that? Evil...
Comment 5 Ciaran McCreesh 2004-10-08 08:39:51 UTC
4.1-r2 fixed.