Lensfun project has finally released a new version of Lensfun along with over 200 profile updates, api changes & more. Unfortunatelly api changes create huge incompatibility between new lensfun version and applications like darktable so it would be good to introduce slots for lensfun. More info at http://lensfun.sourceforge.net/changelog/2018/06/29/Release-0.3.95-Changelog/
Indeed, additional list of lenses supported by the recent version of lensfun has been much awaited. It would be great to make it available via gentoo ecosystem.
Thanks for the heads up, I've added it in my overlay. Tests seem to fail here... https://gitweb.gentoo.org/dev/maekke.git/commit/?id=d93c87fb396ef842f3394e2cdb73db2bcb7cece5
Thanks for the prompt response. I'm sorry, but I have doubts interpreting your statement "Tests seem to fail here...". I downloaded and then built lensfun 0.3.95 with default and ebuild-suggested options with success (though I do see plenty of warnings). Please see my console output attached. Could you clarify what exactly fails on your side?
Created attachment 556146 [details] lensfun 0.3.95 manual build
(In reply to Vasyl Tretiakov from comment #3) > Thanks for the prompt response. > > I'm sorry, but I have doubts interpreting your statement "Tests seem to fail > here...". if you use the ebuild from my overlay and emerge with with FEATURES=test enabled, the test suite of this version fails (which is a regression). 92% tests passed, 2 tests failed out of 26 Total Test time (real) = 9.49 sec The following tests FAILED: 8 - Modifier_coord_perspective_correction (OTHER_FAULT) 19 - Modifier_coord_perspective_correction_deprecated (OTHER_FAULT) Errors while running CTest * ERROR: media-libs/lensfun-0.3.95::maekke failed (test phase): * Tests failed. When you file a bug, please attach the following file: * /var/tmp/portage/media-libs/lensfun-0.3.95/work/lensfun-0.3.95_build/Testing/Temporary/LastTest.log *
Thanks for the clarification. Interestingly, in my local manual build (following previously presented case) all tests succeed. vasyl.tretiakov@localhost ~/Downloads/lensfun-0.3.95/build $ make test Running tests... Test project /home/vasyl.tretiakov/Downloads/lensfun-0.3.95/build Start 1: Database 1/26 Test #1: Database ........................................... Passed 0.32 sec Start 2: Lens 2/26 Test #2: Lens ............................................... Passed 0.01 sec Start 3: Modifier 3/26 Test #3: Modifier ........................................... Passed 0.01 sec Start 4: Modifier_performance 4/26 Test #4: Modifier_performance ............................... Passed 0.81 sec Start 5: Modifier_color 5/26 Test #5: Modifier_color ..................................... Passed 0.31 sec Start 6: Modifier_subpix 6/26 Test #6: Modifier_subpix .................................... Passed 0.05 sec Start 7: Modifier_coord_scale 7/26 Test #7: Modifier_coord_scale ............................... Passed 0.02 sec Start 8: Modifier_coord_perspective_correction 8/26 Test #8: Modifier_coord_perspective_correction .............. Passed 0.01 sec Start 9: Modifier_coord_distortion 9/26 Test #9: Modifier_coord_distortion .......................... Passed 0.06 sec Start 10: Modifier_coord_geometry 10/26 Test #10: Modifier_coord_geometry ............................ Passed 4.11 sec Start 11: Modifier_coord_tiny_image 11/26 Test #11: Modifier_coord_tiny_image .......................... Passed 0.02 sec Start 12: Modifier_coord_centering 12/26 Test #12: Modifier_coord_centering ........................... Passed 0.01 sec Start 13: Modifier_regression 13/26 Test #13: Modifier_regression ................................ Passed 0.61 sec Start 14: Database_deprecated 14/26 Test #14: Database_deprecated ................................ Passed 0.17 sec Start 15: Modifier_deprecated 15/26 Test #15: Modifier_deprecated ................................ Passed 0.01 sec Start 16: Modifier_color_deprecated 16/26 Test #16: Modifier_color_deprecated .......................... Passed 0.30 sec Start 17: Modifier_subpix_deprecate 17/26 Test #17: Modifier_subpix_deprecate .......................... Passed 0.06 sec Start 18: Modifier_coord_scale_deprecated 18/26 Test #18: Modifier_coord_scale_deprecated .................... Passed 0.02 sec Start 19: Modifier_coord_perspective_correction_deprecated 19/26 Test #19: Modifier_coord_perspective_correction_deprecated ... Passed 0.01 sec Start 20: Modifier_coord_distortion_deprecated 20/26 Test #20: Modifier_coord_distortion_deprecated ............... Passed 0.06 sec Start 21: Modifier_coord_geometry_deprecated 21/26 Test #21: Modifier_coord_geometry_deprecated ................. Passed 4.15 sec Start 22: Modifier_coord_tiny_image_deprecated 22/26 Test #22: Modifier_coord_tiny_image_deprecated ............... Passed 0.01 sec Start 23: Modifier_coord_centering_deprecated 23/26 Test #23: Modifier_coord_centering_deprecated ................ Passed 0.01 sec Start 24: Modifier_regression_deprecated 24/26 Test #24: Modifier_regression_deprecated ..................... Passed 0.57 sec Start 25: test_lffuzzystrcmp 25/26 Test #25: test_lffuzzystrcmp ................................. Passed 0.01 sec Start 26: Database_integrity 26/26 Test #26: Database_integrity ................................. Passed 0.50 sec 100% tests passed, 0 tests failed out of 26 Total Test time (real) = 12.24 sec Should I try to reproduce with ebuild in your overlay? If yes, could you remind me how to add your overlay (as I have not worked with overlays for a while, sorry).
I've just noticed a Windows version of darktable ships with lensfun 0.3.95...
There's set of problems with lensfun api in 0.3.95 - as I've learned images modified with older lensfun vs newer are different on same set of parms. Recently in lensfun repo there were code changes to alleviate this problem. Waiting for new release can wait till api stabilizes.
should we switch to https://github.com/lensfun/lensfun Are there issues on https://github.com/lensfun/lensfun/issues which are related to our planned version bump?
(In reply to Hubert Kowalski from comment #0) > Lensfun project has finally released a new version of Lensfun along with > over 200 profile updates, api changes & more. > > Unfortunatelly api changes create huge incompatibility between new lensfun > version and applications like darktable so it would be good to introduce > slots for lensfun. > > More info at > http://lensfun.sourceforge.net/changelog/2018/06/29/Release-0.3.95-Changelog/ This is an alpha release and the code is according to upstream website mostly abandoned. If we bump it it will be at most without keywords...
(In reply to Jonas Stein from comment #9) > should we switch to https://github.com/lensfun/lensfun Yes
