Bug 66173 – udhcp-0.9.8 fails to compile with gcc 3.4 and fails to act on signals

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jonathan Hudson 2004-10-02 17:02:28 UTC]

Two trivial fixes for udhcp-0.9.8

(a) At line 134, the lack of a break statement causes compilation to fail on recent gcc

(b) At line 534, a buggy sizeof means signals are nver acted upon.

Patch will be attached once I get to that stage :-).

Reproducible: Always
Steps to Reproduce:
1. Try to build, it fails
2. FIx (a) above, it compiles
3. Run it, send SIGUSR1 --- nothing happens.

Actual Results:  
Nothing!

Expected Results:  
renew lease

Patch to follow ...

I told the upstream author about these issues 28 Jul 2003 14:55:06 +0100
and was told the signal patch was in CVS ... alas.

[Comment 1 Jonathan Hudson 2004-10-02 17:03:04 UTC]

Created attachment 40959 [details, diff]
patch for udhcpc issues

[Comment 2 Jonathan Hudson 2004-10-03 02:28:28 UTC]

Changed hardware to PPC (in fact any big endian). 
Obvious when you see that sizeof(signal) == 1 and sizeof(sig) == sizeof(int).

[Comment 3 Karol Wojtaszek (RETIRED) 2004-10-06 23:06:24 UTC]

Already fixed in udhcp-0.9.8-r3.

[Comment 4 SpanKY 2004-12-03 17:57:35 UTC]

not really fixed ...

[Comment 5 SpanKY 2004-12-16 20:27:46 UTC]

udhcp-0.9.9_pre20041216 now in portage