Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 661618 - =dev-util/buildbot-1.1.2 initd missing checkconfig default for RUNTIME_PYTHON
Summary: =dev-util/buildbot-1.1.2 initd missing checkconfig default for RUNTIME_PYTHON
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Brian Dolbec
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2018-07-19 19:42 UTC by Daniel M. Weeks
Modified: 2018-08-01 16:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel M. Weeks 2018-07-19 19:42:52 UTC
* Starting buildmaster in xxx ...
 * start-stop-daemon: failed to exec `': Bad file descriptor
 * start-stop-daemon: failed to start `'
 [ !! ]
 * ERROR: buildmaster.xxx failed to start

No default is set for RUNTIME_PYTHON by checkconfig in initd. See also =dev-util/buildbot-worker-1.1.2 where this is handled correctly.

Reproducible: Always
Comment 1 Jonas Stein gentoo-dev 2018-07-21 15:10:31 UTC
Thank you for the report. Please recompile and *attach* the logfiles and 
paste the emerge info as described on
https://wiki.gentoo.org/wiki/Attach_the_logs_to_the_bug_ticket
Please reopen this ticket (Status:unconfirmed) afterwards.
Comment 2 Daniel M. Weeks 2018-07-22 16:32:26 UTC
(In reply to Jonas Stein from comment #1)
> Thank you for the report. Please recompile and *attach* the logfiles and 
> paste the emerge info as described on
> https://wiki.gentoo.org/wiki/Attach_the_logs_to_the_bug_ticket
> Please reopen this ticket (Status:unconfirmed) afterwards.

Neither of those is necessary understand where the issue is here and it doesn't make sense.
Comment 3 Brian Dolbec (RETIRED) gentoo-dev 2018-07-26 17:40:23 UTC
It seems you failed to update conf.d/buildbot when you upgraded/re-emerged buildbot

I have updated the init script to make the python version used configurable since there are several that it can run with.

A couple things to remember:

 1) this is the same conf.d setting as the buildbot-worker conf.d. 
    And has been been for numerous releases.
 2) Both the worker and the master should be on the same python
    At least both either python-2 or python-3 (there were compatibility issues 
    between the master on one, the worker on the other)

You only need to update your conf.d/buildbot, set the correct RUNTIME_PYTHON you want/need to run it with.


The reason this is done is due to eselect-python.  Earlier releases of Buildbot had compatibility issues with py3, also py3.4 was not initially supported due to failures.   At least at my work our buildbot images have different versions of python enabled as the default than what we want to run/have tested our buildbot builders with.
Comment 4 Daniel M. Weeks 2018-07-26 17:55:17 UTC
(In reply to Brian Dolbec from comment #3)
> 
>  1) this is the same conf.d setting as the buildbot-worker conf.d. 
>     And has been been for numerous releases.

Yes, I know and that's the source of the issue. It's not treated the same way by both *init scripts*!

From git:
diff -u dev-util/buildbot/files/buildmaster.initd dev-util/buildbot-worker/files/buildbot_worker.initd2

...
+       if [ ! -e "${RUNTIME_PYTHON}" ]; then
+               RUNTIME_PYTHON="/usr/bin/python"
+       fi
...

There is no check in the buildmaster *initd*. A default install is broken because RUNTIME_PYTHON is unset in the default confd!
Comment 5 Brian Dolbec (RETIRED) gentoo-dev 2018-07-26 18:15:51 UTC
DOH!, sorry, I missed that.  Fixed...