Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 66160 - repoman doesn't like special shell characters in metadata.xml
Summary: repoman doesn't like special shell characters in metadata.xml
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2004-10-02 14:14 UTC by Sven Wegener
Modified: 2005-07-14 06:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
repoman-xmllint.patch (repoman-xmllint.patch,1.03 KB, patch)
2004-10-02 14:15 UTC, Sven Wegener 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Wegener gentoo-dev 2004-10-02 14:14:32 UTC 
Hi,

repoman doesn't like certain special shell characters, like `.

sven@luna /usr/portage/app-arch/afio $ repoman

not in a CVS repository, enabling pretend mode

We're not in PORTDIR... setting to: /usr/portage

RepoMan pretends to scour the neighborhood...
sh: -c: line 13: unexpected EOF while looking for matching ``'
sh: -c: line 18: syntax error: unexpected end of file
!!!

  metadata.bad         1
   app-arch/afio/metadata.xml

Attached is a patch, that modifies repoman not to echo the contents to xmllint
but to call xmllint directly on the file.

I also thought about using the libxml2 python bindings. But they currently
don't offer a way to validate a xml file against a dtd.
Comment 1 Sven Wegener gentoo-dev 2004-10-02 14:15:54 UTC 
Created attachment 40952 [details, diff]
repoman-xmllint.patch

Patch against current CVS version of repoman.
Comment 2 Jason Stubbs (RETIRED) gentoo-dev 2005-01-28 22:57:40 UTC 
Sorry for the delay..
Comment 3 Jason Stubbs (RETIRED) gentoo-dev 2005-07-14 05:47:45 UTC 
Fixed on or before 2.0.51.22-r1
Comment 4 Jason Stubbs (RETIRED) gentoo-dev 2005-07-14 06:58:31 UTC 
Looking through the batch of bugs, I'm not sure that some of these are 
actually fixed in stable. Others, the requirements have possibly changed after 
the initial fix was committed. 
 
If you think this bug has been closed incorrectly, please reopen or ask that 
it be reopened.